soulcraft/brainy
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions

fix(src/utils): enhance type definition and improve load function detection

Browse source 
- Updated `findUSELoadFunction` return type for better type safety and clarity.
- Enhanced load function detection logic with improved readability and consistency.
- Applied formatting adjustments, such as line breaks and removal of redundant semicolons, to adhere to coding standards.

These changes ensure stronger type enforcement, align with project style guidelines, and improve maintainability of Universal Sentence Encoder initialization logic.
This commit is contained in:
David Snelling 2025-06-30 09:39:16 -07:00
parent b4f1f2d1c5
commit 7099667279
1 changed files with 18 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/utils/embedding.ts
View file

@ -260,7 +260,7 @@ export class UniversalSentenceEncoder implements EmbeddingModel {
* @param sentenceEncoderModule The imported module
* @returns The load function or null if not found
*/
function findUSELoadFunction(sentenceEncoderModule: any): Function | null {
function findUSELoadFunction(sentenceEncoderModule: any): (() => Promise<EmbeddingModel>) | null {
// Log the module structure for debugging
console.log(
'Universal Sentence Encoder module structure:',
@ -326,31 +326,37 @@ function findUSELoadFunction(sentenceEncoderModule: any): Function | null {
for (const key in sentenceEncoderModule) {
if (typeof sentenceEncoderModule[key] === 'function') {
// Check if the function name or key contains 'load'
const fnName = sentenceEncoderModule[key].name || key;
const fnName = sentenceEncoderModule[key].name || key
if (fnName.toLowerCase().includes('load')) {
loadFunction = sentenceEncoderModule[key];
console.log(`Using sentenceEncoderModule.${key} as load function`);
break;
loadFunction = sentenceEncoderModule[key]
console.log(`Using sentenceEncoderModule.${key} as load function`)
break
}
}
// Also check nested objects
else if (typeof sentenceEncoderModule[key] === 'object' && sentenceEncoderModule[key] !== null) {
else if (
typeof sentenceEncoderModule[key] === 'object' &&
sentenceEncoderModule[key] !== null
) {
for (const nestedKey in sentenceEncoderModule[key]) {
if (typeof sentenceEncoderModule[key][nestedKey] === 'function') {
const fnName = sentenceEncoderModule[key][nestedKey].name || nestedKey;
const fnName =
sentenceEncoderModule[key][nestedKey].name || nestedKey
if (fnName.toLowerCase().includes('load')) {
loadFunction = sentenceEncoderModule[key][nestedKey];
console.log(`Using sentenceEncoderModule.${key}.${nestedKey} as load function`);
break;
loadFunction = sentenceEncoderModule[key][nestedKey]
console.log(
`Using sentenceEncoderModule.${key}.${nestedKey} as load function`
)
break
}
}
}
if (loadFunction) break;
if (loadFunction) break
}
}
}
return loadFunction;
return loadFunction
}
/**