From 70996672790d9cbb5ff3f51c770be934a8a0c6c3 Mon Sep 17 00:00:00 2001
From: David Snelling <david@soulcraft.com>
Date: Mon, 30 Jun 2025 09:39:16 -0700
Subject: [PATCH] fix(src/utils): enhance type definition and improve load
 function detection

- Updated `findUSELoadFunction` return type for better type safety and clarity.
- Enhanced load function detection logic with improved readability and consistency.
- Applied formatting adjustments, such as line breaks and removal of redundant semicolons, to adhere to coding standards.

These changes ensure stronger type enforcement, align with project style guidelines, and improve maintainability of Universal Sentence Encoder initialization logic.
---
 src/utils/embedding.ts | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/src/utils/embedding.ts b/src/utils/embedding.ts
index 1c130869..f51fd9da 100644
--- a/src/utils/embedding.ts
+++ b/src/utils/embedding.ts
@@ -260,7 +260,7 @@ export class UniversalSentenceEncoder implements EmbeddingModel {
  * @param sentenceEncoderModule The imported module
  * @returns The load function or null if not found
  */
-function findUSELoadFunction(sentenceEncoderModule: any): Function | null {
+function findUSELoadFunction(sentenceEncoderModule: any): (() => Promise<EmbeddingModel>) | null {
   // Log the module structure for debugging
   console.log(
     'Universal Sentence Encoder module structure:',
@@ -326,31 +326,37 @@ function findUSELoadFunction(sentenceEncoderModule: any): Function | null {
     for (const key in sentenceEncoderModule) {
       if (typeof sentenceEncoderModule[key] === 'function') {
         // Check if the function name or key contains 'load'
-        const fnName = sentenceEncoderModule[key].name || key;
+        const fnName = sentenceEncoderModule[key].name || key
         if (fnName.toLowerCase().includes('load')) {
-          loadFunction = sentenceEncoderModule[key];
-          console.log(`Using sentenceEncoderModule.${key} as load function`);
-          break;
+          loadFunction = sentenceEncoderModule[key]
+          console.log(`Using sentenceEncoderModule.${key} as load function`)
+          break
         }
       }
       // Also check nested objects
-      else if (typeof sentenceEncoderModule[key] === 'object' && sentenceEncoderModule[key] !== null) {
+      else if (
+        typeof sentenceEncoderModule[key] === 'object' &&
+        sentenceEncoderModule[key] !== null
+      ) {
         for (const nestedKey in sentenceEncoderModule[key]) {
           if (typeof sentenceEncoderModule[key][nestedKey] === 'function') {
-            const fnName = sentenceEncoderModule[key][nestedKey].name || nestedKey;
+            const fnName =
+              sentenceEncoderModule[key][nestedKey].name || nestedKey
             if (fnName.toLowerCase().includes('load')) {
-              loadFunction = sentenceEncoderModule[key][nestedKey];
-              console.log(`Using sentenceEncoderModule.${key}.${nestedKey} as load function`);
-              break;
+              loadFunction = sentenceEncoderModule[key][nestedKey]
+              console.log(
+                `Using sentenceEncoderModule.${key}.${nestedKey} as load function`
+              )
+              break
             }
           }
         }
-        if (loadFunction) break;
+        if (loadFunction) break
       }
     }
   }
 
-  return loadFunction;
+  return loadFunction
 }
 
 /**