David Snelling
7b67db4d0c
A first adopter's namespace migration went 341 red on one class: the never-carried-field refusal firing on CORRECT filters against fresh and sparse stores — a freshly provisioned tenant refused its own first filtered read, with the did-you-mean built for typos firing hardest on day-one stores where nothing is wrong. The ruled cut: a WHERE filter naming a field no row carries is SERVED OPERATOR-TRUTHFULLY — eq/in/range/contains answer [] (nothing carries it, nothing matches); ne and exists:false answer ALL rows (the equally true complement — a blanket empty here would be silently wrong, which is why the simpler cut was rejected); exists:true answers []. Served from the field registry, with the did-you-mean demoted to a once-per-field WARN. orderBy and genuinely ambiguous addresses KEEP their hard typed refusals: no truthful order exists over an uncarried field, and ambiguity is a contract error while absence is data. Mechanics: the negative operator absorbs the FIELD_NOT_INDEXED throw as its empty exclude set (the clause-level catch correctly zeroes positive operators only); the egress matcher already agreed. Plus the provider-seam belt: a field refusal thrown by a replacement metadata manager is normalized to THIS package's UnresolvableFieldError at every filter call site — one class identity for consumers, instanceof works (a first adopter's cross-package finding). Conformance: tests/conformance/sparse-store-cut.test.ts — the shared operator rows both engines run (positive-empty, negative-all, fresh-tenant day-one, orderBy refusal kept, compound composition). Gates: unit 2065/2065 · integration 832 · conformance 36/36.
87 lines
4 KiB
TypeScript
87 lines
4 KiB
TypeScript
/**
|
|
* @module tests/unit/test-suite-coverage-guard
|
|
* @description Prevents a test file from silently falling outside EVERY vitest
|
|
* config (so it never runs and gives false coverage confidence — the exact drift
|
|
* that left ~27 test files un-run before 8.0). Every `*.test.ts` must either match
|
|
* a gate config (`tests/unit/**`, `tests/integration/**`, `*.unit.test.ts`,
|
|
* `*.integration.test.ts`) or be explicitly listed in MANUAL_ONLY below.
|
|
*/
|
|
import { describe, it, expect } from 'vitest'
|
|
import { readdirSync } from 'node:fs'
|
|
import { join, relative, dirname } from 'node:path'
|
|
import { fileURLToPath } from 'node:url'
|
|
|
|
const repoRoot = join(dirname(fileURLToPath(import.meta.url)), '../..')
|
|
const testsDir = join(repoRoot, 'tests')
|
|
|
|
function allTestFiles(dir: string, out: string[] = []): string[] {
|
|
for (const e of readdirSync(dir, { withFileTypes: true })) {
|
|
const p = join(dir, e.name)
|
|
if (e.isDirectory()) allTestFiles(p, out)
|
|
else if (e.isFile() && p.endsWith('.test.ts')) out.push(relative(repoRoot, p).split('\\').join('/'))
|
|
}
|
|
return out
|
|
}
|
|
|
|
/**
|
|
* Test files INTENTIONALLY excluded from the unit/integration gate: benchmarks,
|
|
* scale/perf measurements, package-size checks, and real-model-load checks. They
|
|
* are run manually (slow / need real resources), not in CI. Every entry is a
|
|
* conscious decision — a NEW orphan not listed here fails the guard below.
|
|
*/
|
|
const MANUAL_ONLY = new Set<string>([
|
|
// Conformance suites run as an explicit gate stage (both engines run them
|
|
// by direct invocation), never swept into the unit/integration configs.
|
|
'tests/conformance/collider-fidelity.test.ts',
|
|
// Golden-log fold-conformance oracle: the two-implementation contract pin
|
|
// (byte + fold digests) — runs in the explicit conformance gate stage,
|
|
// same invocation family as the other conformance suites.
|
|
'tests/conformance/golden-log-fold.test.ts',
|
|
// The sparse-store cut's shared operator rows (both engines run these):
|
|
// explicit conformance-gate invocation, like its siblings.
|
|
'tests/conformance/sparse-store-cut.test.ts',
|
|
'tests/api/performance-benchmarks.test.ts',
|
|
'tests/critical-neural-validation.test.ts',
|
|
'tests/critical-performance-benchmark.test.ts',
|
|
'tests/model-loading.test.ts',
|
|
'tests/package-size-breakdown.test.ts',
|
|
'tests/package-size-limit.test.ts',
|
|
'tests/performance/graph-scale-performance.test.ts',
|
|
'tests/performance/triple-intelligence-scale.test.ts',
|
|
'tests/performance/typeAware.bench.test.ts',
|
|
// Cross-engine field-addressing conformance suite: pinned bit-for-bit against
|
|
// the native accelerator's implementation of the SAME contract, and invoked
|
|
// directly (`npx vitest run tests/conformance/namespace-law.test.ts`), never
|
|
// swept into the unit/integration gates — a run against a branch where the
|
|
// resolver hasn't landed yet must SKIP loudly (see the file's own SELF-SKIP
|
|
// doc), not silently pass/fail as a side effect of which gate happened to
|
|
// pick it up.
|
|
'tests/conformance/namespace-law.test.ts'
|
|
])
|
|
|
|
function inGate(rel: string): boolean {
|
|
return (
|
|
rel.startsWith('tests/unit/') ||
|
|
rel.startsWith('tests/integration/') ||
|
|
rel.endsWith('.unit.test.ts') ||
|
|
rel.endsWith('.integration.test.ts')
|
|
)
|
|
}
|
|
|
|
describe('test-suite coverage guard', () => {
|
|
it('every *.test.ts runs in a gate config or is explicitly allowlisted as manual', () => {
|
|
const orphans = allTestFiles(testsDir).filter((f) => !inGate(f) && !MANUAL_ONLY.has(f))
|
|
expect(
|
|
orphans,
|
|
'These test files match NO vitest config and are not in MANUAL_ONLY — rename to ' +
|
|
'*.unit.test.ts / *.integration.test.ts (or move under tests/unit|integration), or add to ' +
|
|
`MANUAL_ONLY if they are benchmarks:\n${orphans.join('\n')}`
|
|
).toEqual([])
|
|
})
|
|
|
|
it('the manual allowlist has no stale entries (every listed file still exists)', () => {
|
|
const all = new Set(allTestFiles(testsDir))
|
|
const stale = [...MANUAL_ONLY].filter((f) => !all.has(f))
|
|
expect(stale, `MANUAL_ONLY lists files that no longer exist — remove them:\n${stale.join('\n')}`).toEqual([])
|
|
})
|
|
})
|