David Snelling
42e2da259b
Two gate failures on main, one real and one long-hidden. THE HEALTH-GATE PIN encoded the old law — "narrates once per generation, twice across a generation bump" — which the content-keyed dedupe deliberately replaced. A provider's `generation` bumps on every ledger mutation and every rebuild boundary, so keying narration on it re-printed an unchanged health line on every read that consulted a busy provider, and let a provider that never bumped suppress a line whose reasons had genuinely changed. The pin now asserts BOTH directions: an unchanged verdict stays silent however the counter moves, and a changed verdict is always heard. THE VFS HYBRID-SEARCH SUITE configured its store with `options.basePath`, an alias removed at the 8.0 major that configures nothing. The suite was therefore never using its temp directory — it opened the DEFAULT store, shared with every other run on the machine, and accumulated tens of thousands of rows until it failed on that shared store's graph adjacency instead of on anything it tests. It now passes `storage.path`. The suite drops from 6.5s to 0.3s, which is the measure of how much foreign data it had been opening. Neither failure was caused by the release branch; the first is the branch's own behaviour change meeting its outdated pin, the second predates it.
86 lines
2.6 KiB
TypeScript
86 lines
2.6 KiB
TypeScript
/**
|
|
* Hybrid Search VFS Integration Tests
|
|
*
|
|
* Verifies that hybrid search works correctly with VFS entities:
|
|
* file content is searchable by default, and `excludeVFS` filters
|
|
* VFS entities out of results.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
|
|
import { Brainy } from '../../src/brainy'
|
|
import { NounType } from '../../src/types/graphTypes'
|
|
import * as fs from 'fs'
|
|
import * as path from 'path'
|
|
import * as os from 'os'
|
|
|
|
describe('Hybrid Search with VFS', () => {
|
|
let brain: Brainy<any>
|
|
let testDir: string
|
|
|
|
beforeEach(async () => {
|
|
testDir = path.join(os.tmpdir(), `brainy-hybrid-vfs-test-${Date.now()}`)
|
|
fs.mkdirSync(testDir, { recursive: true })
|
|
|
|
// `storage.path`, NOT the pre-8.0 `options.basePath` alias. That alias was
|
|
// removed at the 8.0 major and configures nothing, so this suite silently
|
|
// opened the DEFAULT store instead of its own temp directory — sharing one
|
|
// on-disk brain with every other run on the machine, accumulating tens of
|
|
// thousands of rows, and eventually failing on that shared store's graph
|
|
// adjacency rather than on anything it was written to test.
|
|
brain = new Brainy({ requireSubtype: false,
|
|
storage: {
|
|
type: 'filesystem',
|
|
path: testDir
|
|
}
|
|
})
|
|
await brain.init()
|
|
})
|
|
|
|
afterEach(async () => {
|
|
await brain.close()
|
|
// Cleanup test directory
|
|
try {
|
|
fs.rmSync(testDir, { recursive: true, force: true })
|
|
} catch (e) {
|
|
// Ignore cleanup errors
|
|
}
|
|
})
|
|
|
|
it('should include VFS file content in hybrid search', async () => {
|
|
// Write a file via VFS
|
|
const vfs = brain.vfs
|
|
await vfs.writeFile('/docs/readme.txt', 'This is a readme file with important information')
|
|
|
|
// Search should find VFS content
|
|
const results = await brain.find({
|
|
query: 'readme important',
|
|
limit: 10
|
|
})
|
|
|
|
// VFS entities should appear in results
|
|
expect(results.length).toBeGreaterThan(0)
|
|
})
|
|
|
|
it('should exclude VFS with excludeVFS flag in hybrid search', async () => {
|
|
// Add regular entity
|
|
const entityId = await brain.add({
|
|
data: 'regular document about readme files',
|
|
type: NounType.Document,
|
|
metadata: { source: 'api' }
|
|
})
|
|
|
|
// Write VFS file
|
|
await brain.vfs.writeFile('/readme.md', 'VFS readme content')
|
|
|
|
// Search with excludeVFS should only find regular entity
|
|
const results = await brain.find({
|
|
query: 'readme',
|
|
excludeVFS: true,
|
|
limit: 10
|
|
})
|
|
|
|
expect(results.some(r => r.id === entityId)).toBe(true)
|
|
// VFS entities should be excluded
|
|
expect(results.every(r => !r.metadata?.vfsType)).toBe(true)
|
|
})
|
|
})
|