soulcraftlabs/open-brainy
Archived
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 345 Packages Wiki Activity

test(batch): the batch-vs-individual timing assertion runs in the perf lane, not the correctness gate
Some checks failed
Delta Gate / Delta gate — candidate vs control (push) Waiting to run
CI / Node 22 (push) Successful in 12m27s
CI / Bun (latest) (push) Has been cancelled
CI / Node 24 (push) Has been cancelled
CI / Integration + conformance (Node 22) (push) Has been cancelled

Browse source 
The wall-clock ratio (batch faster than N individual gets) started failing
under the exclusive release gate because individual gets got faster on
this candidate (open-path/hydration changes), not because batchGet
regressed — a perf assertion misclassified into a correctness file.

Skip it under the default gate via a BRAINY_PERF_LANE env marker the perf
config sets for itself; the file joins the perf config's include list so
the case still runs (with every other test in the file) under
`npm run test:perf`.
This commit is contained in:
David Snelling 2026-09-02 11:54:29 -07:00
parent 2c5e34748e
commit ebb3a4bf13
2 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/configs/vitest.perf.config.ts
View file

@ -21,6 +21,13 @@ export default defineConfig({
setupFiles: ['./tests/setup.ts'],
environment: 'node',
// The marker a test uses to tell it is running under this lane (see
// tests/integration/storage-batch-operations.test.ts's batch-vs-
// individual timing case) — a wall-clock RATIO assertion self-skips
// with a reason when this is absent, rather than flaking the
// correctness gate on whichever path happens to be faster this build.
env: { BRAINY_PERF_LANE: '1' },
// Sequential, single fork — same isolation the gate uses, so a perf
// measurement isn't skewed by sibling test contention.
pool: 'forks',
@ -45,7 +52,12 @@ export default defineConfig({
'tests/critical-performance-benchmark.test.ts',
'tests/api/performance-benchmarks.test.ts',
'tests/package-size-limit.test.ts',
'tests/model-loading.test.ts'
'tests/model-loading.test.ts',
// Not a whole perf file — one wall-clock-ratio case inside an
// otherwise-correctness integration suite (self-skipped everywhere
// else via BRAINY_PERF_LANE). Stays in the integration gate's
// include too, so every OTHER test in the file keeps running there.
'tests/integration/storage-batch-operations.test.ts'
],
reporters: process.env.CI ? ['dot'] : ['basic'],