perf(open): answer "are there any entities?" with one directory read

The 7.x-to-8.0 layout probe runs on the open path of every store that does not
yet carry its completion marker — a restore, a store built by an older release
— and asked whether the canonical tree holds anything by LISTING it: a
recursive walk of every file in every entity directory, to learn a boolean. It
now asks the one-level door added for generation discovery, falling back to the
listing on an adapter that lacks it.

Also files a defect found while ratifying the operator set: the VFS builds its
path-prefix filter as `$startsWith`, an operator no engine spelling accepts,
so vfs.searchFiles({ path }) throws INVALID_QUERY on every call that passes a
path. Pre-existing, unrelated to the operator work, and left as a filing —
a path-prefix search needs a design answer, not a spelling correction.
This commit is contained in:
David Snelling 2026-08-28 11:13:24 -07:00
parent d044355ec1
commit 742a0b0506
2 changed files with 28 additions and 2 deletions

View file

@ -219,6 +219,21 @@ every door contract 1 requires?" — is a set-membership check between their
---
## A defect this work surfaced but did not fix
`src/vfs/VirtualFileSystem.ts` builds a path-prefix filter as
`path: { $startsWith: options.path }` — with a `$` prefix. No operator in this
engine carries a `$`, so `validateWhereFilter()` rejects it with
`INVALID_QUERY` before any index read: **`vfs.searchFiles({ path })` throws
today, on every call that passes a path.** It is pre-existing and unrelated to
the operator work above (the validator refuses it before the index path is
reached), and it is left as a filing rather than fixed here, because the right
answer is a design question — a path-prefix search cannot be served by an
equality/range index, so it needs either a path-segment index or an explicit
in-memory narrow, not a spelling correction.
---
## Summary of what changed in code for this ratification
| item | change |

View file

@ -16732,8 +16732,19 @@ export class Brainy<T = any> implements BrainyInterface<T> {
if (legacyEntityPaths.length === 0) {
// Already flat (root entities, no head-branch entities) → stamp the marker
// so future opens short-circuit. A genuinely empty/fresh dir gets no marker.
const rootEntities = await probe.listRawObjects('entities')
if (rootEntities.length > 0) {
// "Are there any entities?" is answered by ONE directory read, not by a
// recursive listing of every file in the tree: this runs on the open path
// of every store that does not yet carry the marker (a restore, a store
// built by an older release), and on a large store that listing walks the
// whole canonical tree to learn a boolean.
const oneLevel = (
probe as unknown as { listRawPrefixes?: (prefix: string) => Promise<string[]> }
).listRawPrefixes
const hasRootEntities =
typeof oneLevel === 'function'
? (await oneLevel.call(probe, 'entities')).length > 0
: (await probe.listRawObjects('entities')).length > 0
if (hasRootEntities) {
await probe.writeRawObject('_system/migration-layout.json', {
layout: 'flat-v8',
version: 8,