soulcraftlabs/open-brainy
Archived
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 345 Packages Wiki Activity

test(hygiene): close every brain the find suite creates

Browse source 
tests/integration/find-*.test.ts and tests/unit/brainy/find*.test.ts each
opened one or more Brainy instances (via beforeAll/beforeEach) and never
closed them — the leaked instance's cadence timer stays armed for the rest
of the single-forked vitest run and keeps narrating into every later file.

find-unified-integration.test.ts was a real bug, not just a missing hook:
its afterAll called a no-op TestCleanup().cleanup() (nothing was ever
registered with it) and then discarded the brain reference with
`brain = null` — the brain was never actually closed.
This commit is contained in:
David Snelling 2026-09-03 09:06:00 -07:00
parent 4c81d7d4c3
commit 4c344782a7
8 changed files with 37 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/unit/brainy/find.test.ts
View file

@ -1,4 +1,4 @@
import { describe, it, expect, beforeEach } from 'vitest'
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
import { Brainy } from '../../../src/brainy'
import { createAddParams } from '../../helpers/test-factory'
import { NounType } from '../../../src/types/graphTypes'
@ -12,7 +12,11 @@ describe('Brainy.find()', () => {
})
await brain.init()
})
afterEach(async () => {
await brain.close()
})
describe('success paths', () => {
it('should find entities by text query', async () => {
// Arrange