soulcraftlabs/open-brainy
Archived
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 345 Packages Wiki Activity

fix: user metadata named 'level' is a real field everywhere — the engine-internal node layer no longer shadows it in sort/filter/aggregation, and the indexing views stop stamping a phantom 0 into its column; index epoch 2 rebuilds existing brains at first open
Some checks failed
CI / Node 22 (push) Successful in 12m17s
Details
CI / Node 24 (push) Has been cancelled
Details
CI / Bun (latest) (push) Has been cancelled
Details

Browse source 
Also completes the v8.10.2 write-granularity law for the transact() plan
path: a metadata-only batch update never rewrites the vector-bearing noun
record (planUpdate staged the unconditional save the update() fix removed).
Seven pins in tests/integration/level-field-shadow.test.ts including the
reporting consumer's exact repro rows; orderBy JSDoc documents the ordering
contract and the announced field-addressing law.
This commit is contained in:
David Snelling 2026-08-03 11:57:32 -07:00
parent cb717be275
commit 1a09be0628
8 changed files with 259 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/brainy.ts
View file

@ -2123,11 +2123,13 @@ export class Brainy<T = any> implements BrainyInterface<T> {
// If undefined values are included as explicit keys, extractIndexableFields indexes
// them as '__NULL__' entries that removeFromIndex can never clean up (storageMetadata
// omits those keys entirely via conditional spreading, so the fields don't match).
// No `level` here: engine plumbing never enters the indexing view — a
// hardcoded level:0 landed in the SAME flattened index column as user
// metadata named `level`, poisoning it multi-valued ([0, real]).
const entityForIndexing = {
id,
vector,
connections: new Map(),
level: 0,
type: params.type,
...(params.subtype !== undefined && { subtype: params.subtype }),
...(params.visibility !== undefined &&
@ -3102,12 +3104,13 @@ export class Brainy<T = any> implements BrainyInterface<T> {
})
}
// Build entity structure for metadata index (with top-level fields)
// Build entity structure for metadata index (with top-level fields).
// No `level`: engine plumbing never enters the indexing view (it
// poisoned the flattened user `level` column — VENUE-BRAINY-ORDERBY-NOOP).
const entityForIndexing = {
id: params.id,
vector,
connections: new Map(),
level: 0,
type: params.type || existing.type,
subtype: params.subtype !== undefined ? params.subtype : existing.subtype,
...(((params.visibility ?? existing.visibility) ?? 'public') !== 'public' && {
@ -9377,7 +9380,7 @@ export class Brainy<T = any> implements BrainyInterface<T> {
id,
vector,
connections: new Map(),
level: 0,
// no `level` — plumbing never enters the indexing view
type: params.type,
...(params.subtype !== undefined && { subtype: params.subtype }),
...(params.visibility !== undefined &&
@ -9528,7 +9531,7 @@ export class Brainy<T = any> implements BrainyInterface<T> {
id: params.id,
vector,
connections: new Map(),
level: 0,
// no `level` — plumbing never enters the indexing view
type: params.type || existing.type,
subtype: params.subtype !== undefined ? params.subtype : existing.subtype,
...(((params.visibility ?? existing.visibility) ?? 'public') !== 'public' && {
@ -9556,16 +9559,22 @@ export class Brainy<T = any> implements BrainyInterface<T> {
}
plan.operations.push(
new UpdateNounMetadataOperation(this.storage, params.id, updatedMetadata),
new SaveNounOperation(this.storage, {
id: params.id,
vector,
connections: new Map(),
level: 0
})
new UpdateNounMetadataOperation(this.storage, params.id, updatedMetadata)
)
// Noun-record write + HNSW reindex ONLY when the vector side actually
// changed — the same write-granularity law as update(): a metadata-only
// patch must never rewrite the whole vector record. This plan path is the
// one transact() updates ride, so an unconditional save here would
// re-open the read-sweep disk-saturation amplifier for exactly the
// consumers batching their stat touches through transact().
if (needsReindexing) {
plan.operations.push(
new SaveNounOperation(this.storage, {
id: params.id,
vector,
connections: new Map(),
level: 0
}),
new RemoveFromVectorIndexOperation(this.index, params.id, existing.vector),
new AddToVectorIndexOperation(this.index, params.id, vector)
)