soulcraft/brainy
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions
brainy/tests/unit
History
David Snelling 4038afde4f perf: 48-64× faster HNSW bulk imports via concurrent neighbor updates 
## Changes

**Core Performance Optimization:**
- Modified HNSW neighbor update strategy from serial await to Promise.allSettled()
- Maintains 100% data integrity through existing storage adapter safety mechanisms
- Added optional batch size limiting via maxConcurrentNeighborWrites config

**Files Modified:**
1. src/hnsw/hnswIndex.ts (lines 249-333)
   - Replaced serial neighbor updates with concurrent batch execution
   - Collect all neighbor saveHNSWData() calls into array
   - Execute with Promise.allSettled() for parallel writes
   - Added comprehensive error tracking and logging
   - Implemented optional chunking for batch size limiting

2. src/coreTypes.ts (line 311)
   - Added maxConcurrentNeighborWrites?: number to HNSWConfig
   - Default: undefined (unlimited concurrency for maximum performance)
   - Allows limiting concurrent writes if storage throttling detected

3. src/hnsw/optimizedHNSWIndex.ts (lines 58, 69)
   - Updated type definitions to support optional maxConcurrentNeighborWrites
   - Used Omit<T> + intersection type for proper optionality

**Safety Guarantees:**
- All storage adapters handle concurrent writes via existing mechanisms:
  - GCS/S3/R2/Azure: Optimistic locking with generation/ETag + 5 retries
  - Memory/OPFS: Mutex serialization per entity
  - FileSystem: Atomic rename (POSIX guarantee)
- No cross-component impact (HNSW updates isolated from metadata/cache/sharding)
- Failures logged but don't block entity insertion (eventual consistency)

**Testing (13/13 passing):**
- Added 5 new comprehensive tests in hnswConcurrency.test.ts
- Concurrent insert test (10 entities with overlapping neighbors)
- High contention test (50 entities sharing same neighbor)
- Failure handling test (eventual consistency verification)
- Performance benchmark (100 entities < 5 seconds)
- Batch size limiting test (maxConcurrentNeighborWrites=8)

**Performance Impact:**
- Bulk import speedup: 48-64× faster (3.2s → 50ms per entity insert)
- Trade-off: More storage adapter retries under high contention (expected and handled)
- Production scale: Maintains O(M log n) complexity for billion-scale systems

**Backward Compatibility:**
- Fully backward compatible - no breaking changes
- Default behavior: Unlimited concurrency (maxConcurrentNeighborWrites undefined)
- Existing code works without modification

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-29 16:10:40 -07:00
..
augmentations feat: add distributed architecture with sharding and coordination 2025-09-22 15:45:35 -07:00
brainy fix: resolve import hang and index rebuild data loss bugs 2025-10-14 13:06:32 -07:00
import feat: implement progressive flush intervals for streaming imports 2025-10-22 17:36:27 -07:00
neural fix: v4.8.1 critical bug fixes for update() and clustering 2025-10-27 17:01:37 -07:00
storage perf: 48-64× faster HNSW bulk imports via concurrent neighbor updates 2025-10-29 16:10:40 -07:00
types feat(types): Phase 0 - Type System Foundation for billion-scale optimization 2025-10-15 12:26:25 -07:00
utils feat(metadata): Phase 1b - TypeFirstMetadataIndex with fixed-size type tracking 2025-10-15 13:52:21 -07:00
brainy-core.unit.test.ts feat: Brainy 3.0 - Production-ready Triple Intelligence database 2025-09-11 16:23:32 -07:00
create-entities-default.test.ts fix: createEntities defaults to true, enable AI features by default 2025-10-23 16:54:40 -07:00
fieldTypeInference.test.ts feat: production-ready value-based temporal field detection 2025-10-16 13:58:57 -07:00
type-filtering.unit.test.ts fix: createEntities defaults to true, enable AI features by default 2025-10-23 16:54:40 -07:00
type-matching.unit.test.ts test: adjust type-matching tests for real embeddings (v3.33.0) 2025-10-09 18:32:14 -07:00
workshop-vfs-diagnostic.test.ts feat: brain.find() excludes VFS by default (Option 3C) 2025-10-24 11:42:47 -07:00