David Snelling
780fb6444b
Brainy 8.0 makes subtype required by default on every public write path
(`add`, `addMany`, `update`, `relate`, `relateMany`, `updateRelation`,
import). Per the locked C-1 contract, every entity and relation gets a
non-empty subtype string by the time the storage layer sees it.
OPT-OUT REMAINS FULLY SUPPORTED
The runtime flag is still consumer-controlled. Three opt-out paths
cover migration / legacy fixtures / typed escape:
- `new Brainy({ requireSubtype: false })` — last-resort: turn off the
contract entirely. Recommended only for migration windows or test
fixtures that legitimately can't supply a subtype.
- `new Brainy({ requireSubtype: { except: [NounType.Thing, ...] } })` —
per-type allowlist: strict everywhere except the listed types.
- `brain.requireSubtype(type, options)` — per-type registration with
optional vocabulary. Composes with the brain-wide flag.
Default is now `true`. Opt-out is explicit and documented; nothing
silently degrades.
TEST SWEEP
Bulk-applied `requireSubtype: false` to every `new Brainy({...})` call
site across 120 test files. Three sed patterns covered the shapes:
- `new Brainy({` → `new Brainy({ requireSubtype: false,`
- `new Brainy<T>({` → `new Brainy<T>({ requireSubtype: false,`
- `new Brainy()` → `new Brainy({ requireSubtype: false })`
tests/helpers/test-factory.ts → createTestConfig() defaults
`requireSubtype: false` so test files using the helper inherit the
opt-out without per-site edits.
The test sites that DO exercise subtype semantics (the
subtype-and-facets suite, the strict-mode-self-test suite, the verb-
subtype-and-enforcement suite, etc.) already pass real subtypes — they
were the 7.30.x acceptance tests for this contract. Those tests
continue to pass unchanged.
CHANGES
src/brainy.ts
- normalizeConfig() — `requireSubtype` default `false` → `true`.
Comment refreshed to document the three opt-out paths.
tests/* (120 files)
- Bulk-edited brain construction sites. No functional test changes; the
opt-out preserves the test author's original intent.
tests/helpers/test-factory.ts
- createTestConfig() base config gains `requireSubtype: false`.
NO-OP for consumers who were already passing subtype on every write.
For consumers who weren't, the upgrade path is one of the three opt-out
forms above. Migration recipe documented in 8.0 release notes (next
commit).
VERIFICATION
- npx tsc --noEmit: clean
- npm test: 1408 / 1409 (same pre-existing race-condition outstanding;
no other regressions from the flip)
81 lines
2.8 KiB
TypeScript
81 lines
2.8 KiB
TypeScript
/**
|
|
* VFS Debug Test - Minimal reproduction to find the issue
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach } from 'vitest'
|
|
import { Brainy } from '../../src/brainy.js'
|
|
import * as XLSX from 'xlsx'
|
|
|
|
describe('VFS Debug', () => {
|
|
it('minimal VFS writeFile test', async () => {
|
|
const brain = new Brainy({ requireSubtype: false, storage: { type: 'memory' } })
|
|
await brain.init()
|
|
|
|
console.log('✅ Brain initialized')
|
|
|
|
// Get VFS and initialize
|
|
const vfs = brain.vfs
|
|
await vfs.init()
|
|
|
|
console.log('✅ VFS initialized')
|
|
|
|
// Write a single file
|
|
await vfs.writeFile('/test.txt', 'Hello World')
|
|
|
|
console.log('✅ File written')
|
|
|
|
// Check if entity exists using find()
|
|
const allEntities = await brain.find({ limit: 100 })
|
|
console.log(`📊 Total entities (via find): ${allEntities.length}`)
|
|
|
|
console.log('Entities from find() - CHECKING STRUCTURE:')
|
|
allEntities.forEach((e, i) => {
|
|
console.log(` ${i+1}. Result object keys: ${Object.keys(e).join(', ')}`)
|
|
console.log(` e.id: ${e.id}`)
|
|
console.log(` e.score: ${(e as any).score}`)
|
|
console.log(` e.entity: ${(e as any).entity ? 'EXISTS' : 'MISSING'}`)
|
|
if ((e as any).entity) {
|
|
console.log(` e.entity.type: ${(e as any).entity.type}`)
|
|
console.log(` e.entity.metadata: ${JSON.stringify((e as any).entity.metadata)}`)
|
|
}
|
|
console.log(` e.type (direct): ${e.type}`)
|
|
console.log(` e.metadata (direct): ${JSON.stringify(e.metadata)}`)
|
|
})
|
|
|
|
const vfsEntities = allEntities.filter(e => e.metadata?.vfsType)
|
|
console.log(`📊 VFS entities (via find): ${vfsEntities.length}`)
|
|
|
|
// Now try getting entities directly
|
|
console.log('\nChecking entities directly with brain.get():')
|
|
for (const entity of allEntities) {
|
|
const direct = await brain.get(entity.id)
|
|
if (direct) {
|
|
console.log(` ${direct.id}:`)
|
|
console.log(` metadata: ${JSON.stringify(direct.metadata)}`)
|
|
if (direct.metadata?.vfsType) {
|
|
console.log(` ✅ HAS vfsType: ${direct.metadata.vfsType}`)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Try reading the file
|
|
const content = await vfs.readFile('/test.txt')
|
|
console.log(`\n📄 File content: "${content.toString()}"`)
|
|
|
|
// Try VFS directory listing
|
|
console.log('\n📂 VFS Directory Listing:')
|
|
const rootContents = await vfs.readdir('/')
|
|
console.log(` Root contents: ${rootContents.join(', ')}`)
|
|
|
|
// Try getDirectChildren (the consumer's method)
|
|
const children = await vfs.getDirectChildren('/')
|
|
console.log(` Direct children: ${children.length}`)
|
|
children.forEach(child => {
|
|
console.log(` - ${child.metadata.name} (${child.metadata.vfsType})`)
|
|
})
|
|
|
|
// THE REAL TEST: Can we query VFS?
|
|
expect(children.length).toBeGreaterThan(0)
|
|
expect(rootContents.length).toBeGreaterThan(0)
|
|
})
|
|
})
|