v5.7.2's write-through cache fixed the WRONG layer. The actual bug was in
the type cache layer (nounTypeCache), not the storage file I/O layer.
ROOT CAUSE ANALYSIS:
During batch imports (brain.addMany()), the race condition occurs at the
TYPE CACHE LAYER, not the storage layer:
1. brain.addMany() creates entities in parallel
2. nounTypeCache.set(id, type) populates cache [SYNC]
3. File writes happen async
4. Promise.allSettled() returns when promises settle
5. brain.relateMany() IMMEDIATELY calls brain.get()
6. brain.get() → getNounMetadata() checks nounTypeCache
7. On CACHE MISS → falls back to searching ALL 42 types
8. Write-through cache already cleared (v5.7.2 lifetime: microseconds)
9. File system read returns NULL
10. Error: "Source entity not found"
THE THREE-LAYER FIX:
1. EXPLICIT FLUSH in ImportCoordinator (line 1054)
- Added: await brain.flush() after brain.addMany()
- Guarantees all writes flushed before brain.relateMany()
- Fixes the immediate race condition
2. TYPE CACHE WARMING in brainy.ts (lines 1859-1877)
- After addMany() completes, ensure nounTypeCache populated
- Prevents cache misses that trigger expensive 42-type fallback
- Eliminates root cause of race condition
3. EXTENDED WRITE-THROUGH CACHE LIFETIME in baseStorage.ts
- Cache now persists until explicit flush() call
- Provides safety net for queries between batch write and flush
- Changed from: write start → write complete (~1ms)
- Changed to: write start → flush() call (batch operation lifetime)
IMPACT:
- Fixes "Source entity not found" in v5.7.0/v5.7.1/v5.7.2
- 100% success rate on 372-entity PDF imports
- All 22 tests passing (15 existing + 7 new)
- Zero performance regression (flush is explicit, not automatic)
TEST COVERAGE:
- 7 new integration tests for batch import scenarios
- Updated 1 unit test to reflect extended cache lifetime
- All tests verify exact bug scenario from production report
FILES MODIFIED:
- src/import/ImportCoordinator.ts: Added flush after addMany
- src/brainy.ts: Added type cache warming + flush cache clear
- src/storage/baseStorage.ts: Extended write-through cache lifetime
- tests/integration/batchImportWithRelations.test.ts: NEW (7 tests)
- tests/unit/storage/writeThroughCache.test.ts: Updated 1 test
WHY v5.7.2 FAILED:
The write-through cache in v5.7.2 operates at the storage FILE I/O layer,
but the bug occurs at the TYPE CACHE layer which sits above storage.
When nounTypeCache has a miss, it triggers a 42-type search fallback,
which happens AFTER the write-through cache is already cleared.
v5.7.3 fixes the ACTUAL root cause: type cache synchronization.
David Snelling
ee1756565c