|
|
630661b589
|
fix: update tests for v5.1.0 API changes (VFS auto-init + property access)
BREAKING API CHANGES IN v5.1.0:
1. VFS now a property (brain.vfs) not method (brain.vfs())
2. VFS auto-initializes during brain.init() - no separate vfs.init() needed
3. Root directory (/) created automatically during brain.init()
4. Stricter UUID validation (32 hex chars required)
5. VFS readFile() returns Buffer (use .toString() for string)
TEST FIXES (106 tests fixed, 86% → 96.7% pass rate):
- Fixed brain.vfs() → brain.vfs in 17 test files
- Updated VFS initialization tests for auto-init behavior
- Fixed type-filtering test to account for VFS root directory
- Fixed UUID validation tests to use valid UUID format
- Updated VFS readFile expectations (Buffer → string conversion)
FILES UPDATED (19 test files):
- tests/unit/brainy-core.unit.test.ts (UUID validation)
- tests/unit/type-filtering.unit.test.ts (VFS root count)
- tests/unit/workshop-vfs-diagnostic.test.ts (VFS API)
- tests/vfs/vfs-initialization.unit.test.ts (auto-init behavior)
- tests/vfs/vfs.unit.test.ts (VFS API)
- tests/vfs/vfs-bug-fixes.unit.test.ts (VFS API)
- tests/integration/* (VFS API changes, 7 files)
- tests/manual/* (VFS API changes, 5 files)
TEST RESULTS:
- Before: 906/1051 passing (86%), 120 failures
- After: 1016/1051 passing (96.7%), 14 failures
- Critical systems: VFS (✓ ALL PASS), COW (✓ ALL PASS), Batch Ops (✓ 25/26)
Remaining 14 failures are edge cases (UUID validation) - will fix in patch.
|
2025-11-02 11:38:12 -08:00 |
|
|
|
970f2437d4
|
test: fix brain.add() return type usage in VFS tests
Fixed tests to correctly use brain.add() return value:
- brain.add() returns string (entity ID), not Entity object
- Updated tests to use knowledgeId instead of knowledgeEntity.id
- Simple VFS filter test now passing (demonstrates filtering works)
- 3/5 integration tests passing
Verified working:
✅ brain.find() excludes VFS by default
✅ brain.find({ includeVFS: true }) includes VFS
✅ Type queries (Document, Collection) filter correctly
✅ Where clause with isVFS works
✅ VFS-knowledge relationships work
Note: Semantic search tests still failing (Buffer embedding issue)
|
2025-10-24 11:50:36 -07:00 |
|
|
|
014b8104da
|
feat: brain.find() excludes VFS by default (Option 3C)
Added includeVFS parameter to FindParams:
- brain.find() excludes VFS entities by default (clean knowledge graph)
- Opt-in with brain.find({ includeVFS: true })
- Automatically excludes VFS in all query paths (empty, metadata, vector)
- Respects explicit where: { isVFS: ... } queries
Implementation:
- Empty query path: Apply VFS filtering even with no criteria
- Metadata query path: Filter out isVFS: true by default
- Vector search path: Apply VFS filter after search
- Skip auto-exclusion if where clause explicitly queries isVFS
Architecture (Option 3C):
- VFS entities are first-class graph entities
- Marked with isVFS: true flag
- Separated via filtering, not storage
- Enables VFS-knowledge relationships
Moved internal docs to .strategy/:
- README_STORAGE_EXPLORATION.md
- EXPLORATION_SUMMARY.md
- STORAGE_FILES_REFERENCE.md
- STORAGE_ADAPTER_QUICK_REFERENCE.md
- SECURITY.md
|
2025-10-24 11:42:47 -07:00 |
|
