feat: Remove dangerous getAllNouns/getAllVerbs methods, add safe pagination

BREAKING CHANGE: Removed getAllNouns() and getAllVerbs() from StorageAdapter interface
These methods could cause expensive full scans on cloud storage (S3/R2) leading to
high costs and performance issues. Replaced with safe paginated methods.

Changes:
- Remove getAllNouns/getAllVerbs from StorageAdapter interface and implementations
- Add internal optimization methods for intelligent preloading when safe
- Fix OPFS storage file naming consistency (.json extension)
- Fix S3 high-volume mode detection thresholds (was too aggressive)
- Fix TypeScript compilation errors with async methods
- Update all tests to use paginated methods

Performance:
- Add smart dataset size detection for automatic optimization
- Maintain all internal performance optimizations through safe preloading
- Only preload data in read-only mode or when dataset is small (<10k entities)

Fixes:
- Fix intelligent verb scoring tests metadata structure
- Fix S3 storage getVerbsBySource/Target/Type methods
- Fix memory usage in search operations using pagination

Docs:
- Add comprehensive storage architecture documentation
- Document known bash redirection issue
- Update README with architecture doc link

All affected tests passing
This commit is contained in:
David Snelling 2025-08-10 16:25:12 -07:00
parent d4ef17d1f1
commit fb80808f44
25 changed files with 1071 additions and 390 deletions

View file

@ -97,10 +97,18 @@ describe('OPFSStorage', () => {
expect(retrievedNoun?.connections.get(0)?.has('test-noun-2')).toBe(true)
expect(retrievedNoun?.connections.get(0)?.has('test-noun-3')).toBe(true)
// Test getAllNouns
const allNouns = await opfsStorage.getAllNouns()
expect(allNouns.length).toBe(1)
expect(allNouns[0].id).toBe('test-noun-1')
// Check if the noun is actually stored first
console.log('DEBUG: Checking if noun exists after save')
const storedNoun = await opfsStorage.getNoun('test-noun-1')
console.log('DEBUG: storedNoun:', storedNoun ? 'EXISTS' : 'NOT FOUND')
// Test getNouns with pagination
console.log('DEBUG: About to test getNouns')
const nounsResult = await opfsStorage.getNouns({ pagination: { limit: 10 } })
console.log('DEBUG: getNouns result:', nounsResult.items.length)
expect(nounsResult.items.length).toBe(1)
expect(nounsResult.items[0].id).toBe('test-noun-1')
// Test deleteNoun
await opfsStorage.deleteNoun('test-noun-1')
@ -163,10 +171,10 @@ describe('OPFSStorage', () => {
version: '1.0'
})
// Test getAllVerbs
const allVerbs = await opfsStorage.getAllVerbs()
expect(allVerbs.length).toBe(1)
expect(allVerbs[0].id).toBe('test-verb-1')
// Test getVerbs with pagination
const verbsResult = await opfsStorage.getVerbs({ pagination: { limit: 10 } })
expect(verbsResult.items.length).toBe(1)
expect(verbsResult.items[0].id).toBe('test-verb-1')
// Test getVerbsBySource
const verbsBySource = await opfsStorage.getVerbsBySource('source-noun-1')