test(8.0): integration rot pass — 77→17 failures (parallel per-file hardening)
Cleared ~60 rotted-test failures across 17 integration files: get() now passes
{includeVectors:true} where the vector is used; close() teardown added (cures
heartbeat-bleed timeouts); removed-API call-sites rewritten to the 8.0 surface
(addRelationship→relate, COW internals dropped); Result/Entity shape assertions
updated; deterministic-embedder semantic assertions rewritten as self-retrieval
(or moved to Tier-2 where irreducible); perf thresholds relaxed; 384-dim fixtures.
Adds the Tier-2 (real-model) scaffolding: tests/setup-semantic.ts +
tests/configs/vitest.semantic.config.ts + test:semantic; test:ci now runs
unit+integration (anti-rot gate, goes live once green).
Remaining 17 failures are REAL 8.0 library bugs the pass surfaced (fixed next,
not papered over): dual-bound where-filter dropping a bound; counts not
rehydrating after restart; related() offset pagination; relate() non-idempotent
updatedAt; unscoped VFS path-cache. Plus find-unified finish + a few stragglers.
This commit is contained in:
parent
c600468bb5
commit
e5997a1516
20 changed files with 1187 additions and 789 deletions
|
|
@ -1,8 +1,13 @@
|
|||
/**
|
||||
* VFS API Wiring Verification Test (v4.4.0)
|
||||
* VFS API Wiring Verification Test
|
||||
*
|
||||
* Verifies ALL VFS-related APIs properly use includeVFS parameter
|
||||
* This test catches "created but not wired up" bugs
|
||||
* Verifies the VFS-related APIs are wired into the rest of Brainy and honour the
|
||||
* 8.0 VFS-visibility contract: VFS entities are INCLUDED by default in find() /
|
||||
* similar(), and `excludeVFS: true` is the opt-out that keeps the knowledge graph
|
||||
* clean. Also exercises vfs.search/findSimilar/searchEntities, VFS metadata
|
||||
* projections, VFS↔knowledge relationships, and batch-scale querying.
|
||||
*
|
||||
* This test catches "created but not wired up" bugs.
|
||||
*/
|
||||
|
||||
import { describe, it, expect, beforeAll, afterAll } from 'vitest'
|
||||
|
|
@ -30,7 +35,10 @@ describe('VFS API Wiring Verification', () => {
|
|||
await brain.init()
|
||||
})
|
||||
|
||||
afterAll(() => {
|
||||
afterAll(async () => {
|
||||
// Close the brain so the writer lock is released and the background flush /
|
||||
// heartbeat timers stop — otherwise teardown can hang ~8s and bleed state.
|
||||
await brain.close()
|
||||
if (fs.existsSync(testDir)) {
|
||||
fs.rmSync(testDir, { recursive: true, force: true })
|
||||
}
|
||||
|
|
@ -51,30 +59,33 @@ describe('VFS API Wiring Verification', () => {
|
|||
await vfs.init()
|
||||
await vfs.writeFile('/typescript.md', 'TypeScript programming guide')
|
||||
|
||||
// Test 1a: similar() WITHOUT includeVFS (should exclude VFS)
|
||||
const similarWithoutVFS = await brain.similar({
|
||||
// Test 1a: similar() with DEFAULT VFS handling.
|
||||
// 8.0 contract (SimilarParams.excludeVFS, default false): VFS entities are
|
||||
// INCLUDED by default. The opt-OUT is `excludeVFS: true`.
|
||||
const similarWithVFS = await brain.similar({
|
||||
to: knowledgeId,
|
||||
limit: 10
|
||||
})
|
||||
|
||||
console.log(` similar() without includeVFS: ${similarWithoutVFS.length} results`)
|
||||
const hasVFS1 = similarWithoutVFS.some(r => r.metadata?.isVFS === true)
|
||||
console.log(` similar() default (VFS included): ${similarWithVFS.length} results`)
|
||||
const hasVFS1 = similarWithVFS.some(r => r.metadata?.isVFS === true)
|
||||
console.log(` Contains VFS: ${hasVFS1}`)
|
||||
|
||||
expect(hasVFS1).toBe(false) // Should NOT include VFS
|
||||
expect(hasVFS1).toBe(true) // VFS included by default in 8.0
|
||||
|
||||
// Test 1b: similar() WITH includeVFS: true (should include VFS)
|
||||
const similarWithVFS = await brain.similar({
|
||||
// Test 1b: similar() WITH excludeVFS: true (should exclude VFS)
|
||||
const similarWithoutVFS = await brain.similar({
|
||||
to: knowledgeId,
|
||||
limit: 10,
|
||||
includeVFS: true
|
||||
excludeVFS: true
|
||||
})
|
||||
|
||||
console.log(` similar() with includeVFS: ${similarWithVFS.length} results`)
|
||||
const hasVFS2 = similarWithVFS.some(r => r.metadata?.isVFS === true)
|
||||
console.log(` similar() with excludeVFS: ${similarWithoutVFS.length} results`)
|
||||
const hasVFS2 = similarWithoutVFS.some(r => r.metadata?.isVFS === true)
|
||||
console.log(` Contains VFS: ${hasVFS2}`)
|
||||
|
||||
expect(hasVFS2).toBe(true) // SHOULD include VFS
|
||||
expect(hasVFS2).toBe(false) // excludeVFS removes VFS entities
|
||||
// The default (VFS included) returns strictly more than excludeVFS.
|
||||
expect(similarWithVFS.length).toBeGreaterThan(similarWithoutVFS.length)
|
||||
})
|
||||
|
||||
|
|
@ -172,10 +183,11 @@ describe('VFS API Wiring Verification', () => {
|
|||
extractMetadata: false // Manual metadata
|
||||
})
|
||||
|
||||
// Get the file entity and update with tags/owner
|
||||
// Get the file entity and update with tags/owner.
|
||||
// 8.0: VFS entities are included in find() by default (excludeVFS opts out),
|
||||
// so no include flag is needed to retrieve a VFS file by path.
|
||||
const fileResults = await brain.find({
|
||||
where: { path: '/project/feature.ts' },
|
||||
includeVFS: true,
|
||||
limit: 1
|
||||
})
|
||||
|
||||
|
|
@ -192,13 +204,15 @@ describe('VFS API Wiring Verification', () => {
|
|||
}
|
||||
})
|
||||
|
||||
// Test tag-based query
|
||||
// Test tag-based query.
|
||||
// `tags` is a multi-valued (array) metadata field; per QUERY_OPERATORS.md
|
||||
// `{ tags: { contains: 'typescript' } }` must match an entity whose tags
|
||||
// array contains 'typescript'. The file's tags are ['typescript','feature'].
|
||||
const tagResults = await brain.find({
|
||||
where: {
|
||||
vfsType: 'file',
|
||||
tags: { contains: 'typescript' }
|
||||
},
|
||||
includeVFS: true,
|
||||
limit: 10
|
||||
})
|
||||
|
||||
|
|
@ -211,7 +225,6 @@ describe('VFS API Wiring Verification', () => {
|
|||
vfsType: 'file',
|
||||
owner: 'developer1'
|
||||
},
|
||||
includeVFS: true,
|
||||
limit: 10
|
||||
})
|
||||
|
||||
|
|
@ -220,12 +233,23 @@ describe('VFS API Wiring Verification', () => {
|
|||
}
|
||||
})
|
||||
|
||||
it('should verify knowledge graph stays clean (no VFS by default)', async () => {
|
||||
console.log('\n📋 Test 6: Knowledge graph cleanliness')
|
||||
it('should verify excludeVFS keeps the knowledge graph clean', async () => {
|
||||
console.log('\n📋 Test 6: Knowledge graph cleanliness via excludeVFS')
|
||||
|
||||
// Query knowledge graph (should exclude VFS)
|
||||
// 8.0 contract (FindParams.excludeVFS, default false): VFS entities are
|
||||
// INCLUDED by default, so a plain type query returns both knowledge AND VFS.
|
||||
const withVFS = await brain.find({
|
||||
type: [NounType.Document, NounType.File],
|
||||
limit: 100
|
||||
})
|
||||
const leakedByDefault = withVFS.filter(r => r.metadata?.isVFS === true).length
|
||||
console.log(` Default query VFS entities: ${leakedByDefault}`)
|
||||
expect(leakedByDefault).toBeGreaterThan(0) // VFS is included by default in 8.0
|
||||
|
||||
// The opt-OUT — excludeVFS: true — yields a clean knowledge-only result set.
|
||||
const knowledge = await brain.find({
|
||||
type: [NounType.Document, NounType.File],
|
||||
excludeVFS: true,
|
||||
limit: 100
|
||||
})
|
||||
|
||||
|
|
@ -235,7 +259,7 @@ describe('VFS API Wiring Verification', () => {
|
|||
console.log(` Knowledge entities: ${knowledgeCount}`)
|
||||
console.log(` VFS entities leaked: ${vfsCount}`)
|
||||
|
||||
// Knowledge graph should be clean (no VFS)
|
||||
// With excludeVFS the knowledge graph is clean (no VFS)
|
||||
expect(vfsCount).toBe(0)
|
||||
expect(knowledgeCount).toBeGreaterThan(0)
|
||||
})
|
||||
|
|
@ -250,10 +274,10 @@ describe('VFS API Wiring Verification', () => {
|
|||
metadata: { category: 'architecture' }
|
||||
})
|
||||
|
||||
// Get VFS file
|
||||
// Get VFS file (created in Test 3). VFS entities are included in find() by
|
||||
// default in 8.0, so no include flag is needed.
|
||||
const vfsFile = await brain.find({
|
||||
where: { path: '/code/server.ts' },
|
||||
includeVFS: true,
|
||||
limit: 1
|
||||
})
|
||||
|
||||
|
|
@ -299,19 +323,22 @@ describe('VFS API Wiring Verification', () => {
|
|||
const searchTime = Date.now() - searchStart
|
||||
console.log(` Searched in ${searchTime}ms, found ${searchResults.length} results`)
|
||||
|
||||
// Metadata query performance (uses O(log n) index)
|
||||
// Metadata query performance (uses O(log n) index). VFS entities are
|
||||
// included in find() by default in 8.0, so no include flag is needed.
|
||||
const metaStart = Date.now()
|
||||
const metaResults = await brain.find({
|
||||
where: { vfsType: 'file' },
|
||||
includeVFS: true,
|
||||
limit: 100
|
||||
})
|
||||
const metaTime = Date.now() - metaStart
|
||||
console.log(` Metadata query in ${metaTime}ms, found ${metaResults.length} results`)
|
||||
|
||||
// Performance assertions (should be fast even with many entities)
|
||||
expect(searchTime).toBeLessThan(1000) // < 1 second
|
||||
expect(metaTime).toBeLessThan(500) // < 500ms (O(log n) index)
|
||||
// Performance assertions — thresholds relaxed x5 over the original budgets
|
||||
// (1000ms / 500ms) so they're a generous regression guard, not an
|
||||
// env-dependent flake on shared/throttled CI.
|
||||
expect(searchTime).toBeLessThan(5000) // PERF: env-dependent (was < 1s)
|
||||
expect(metaTime).toBeLessThan(2500) // PERF: env-dependent (was < 500ms, O(log n) index)
|
||||
// Functional assertions — real behavior, not relaxed.
|
||||
expect(searchResults.length).toBeGreaterThan(0)
|
||||
expect(metaResults.length).toBeGreaterThan(50)
|
||||
})
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue