fix: CRITICAL systemic VFS metadata bug across ALL storage adapters (v4.7.4)
CRITICAL BUG FIX - Workshop Team Unblocked! This hotfix resolves a systemic bug affecting ALL 7 storage adapters that caused VFS queries to return empty results even when data existed. Bug Pattern: `if (!metadata) continue` in getNouns()/getVerbs() Impact: VFS queries returned empty arrays despite 577 relationships existing Root Cause: Storage adapters skipped entities if metadata file read returned null Fixes: - storage: Fix metadata skip bug in 12 locations across 7 adapters (TypeAware, Memory, FileSystem, GCS, S3, R2, OPFS, Azure) - neural: Fix SmartExtractor weighted score threshold (28 failures → 4) - neural: Fix PatternSignal priority ordering - api: Fix Brainy.relate() weight parameter not returned Test Results: - TypeAwareStorageAdapter: 17/17 passing (was 7 failures) - SmartExtractor: 42/46 passing (was 28 failures) - Neural clustering: 3/3 passing - Brainy.relate(): 20/20 passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
parent
c75bbb9ba4
commit
e06edb7d52
15 changed files with 287 additions and 144 deletions
|
|
@ -204,8 +204,8 @@ export class MemoryStorage extends BaseStorage {
|
|||
if (!noun) continue
|
||||
|
||||
// Get metadata from separate storage
|
||||
// FIX v4.7.4: Don't skip nouns without metadata - metadata is optional in v4.0.0
|
||||
const metadata = await this.getNounMetadata(id)
|
||||
if (!metadata) continue // Skip if no metadata
|
||||
|
||||
// v4.0.0: Create HNSWNounWithMetadata with metadata field
|
||||
const nounWithMetadata: HNSWNounWithMetadata = {
|
||||
|
|
@ -213,7 +213,7 @@ export class MemoryStorage extends BaseStorage {
|
|||
vector: [...noun.vector],
|
||||
connections: new Map(),
|
||||
level: noun.level || 0,
|
||||
metadata: metadata // Include metadata field
|
||||
metadata: (metadata || {}) as NounMetadata // Include metadata field (empty if none)
|
||||
}
|
||||
|
||||
// Copy connections
|
||||
|
|
@ -466,8 +466,9 @@ export class MemoryStorage extends BaseStorage {
|
|||
if (!hnswVerb) continue
|
||||
|
||||
// Get metadata from separate storage
|
||||
// FIX v4.7.4: Don't skip verbs without metadata - metadata is optional in v4.0.0
|
||||
// Core fields (verb, sourceId, targetId) are in HNSWVerb itself
|
||||
const metadata = await this.getVerbMetadata(id)
|
||||
if (!metadata) continue // Skip if no metadata
|
||||
|
||||
// v4.0.0: Create HNSWVerbWithMetadata with metadata field
|
||||
const verbWithMetadata: HNSWVerbWithMetadata = {
|
||||
|
|
@ -480,8 +481,8 @@ export class MemoryStorage extends BaseStorage {
|
|||
sourceId: hnswVerb.sourceId,
|
||||
targetId: hnswVerb.targetId,
|
||||
|
||||
// Metadata field
|
||||
metadata: metadata
|
||||
// Metadata field (empty if none)
|
||||
metadata: metadata || {}
|
||||
}
|
||||
|
||||
// Copy connections
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue