fix(metadataIndex): flatten custom metadata fields for cleaner queries

v4.8.0 caused metadata filters to fail because custom fields were indexed
with 'metadata.' prefix but queries used flat field names.

Root cause:
- extractIndexableFields() indexed custom fields as 'metadata.category'
- Queries used { category: 'B' } looking for 'category' field
- Result: 0 matches despite entities existing

Solution:
- Flatten custom metadata fields to top-level in index (no prefix)
- Standard fields (type, createdAt, etc.) already at top-level
- Custom fields won't conflict with standard field names
- Now queries work: { category: 'B' } finds 'category' field

Results:
- Fixed 4 more tests (25 → 21 failures)
- All find.test.ts tests passing (17/17)
- Test pass rate: 97.1% (976/1005)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
David Snelling 2025-10-27 15:59:00 -07:00
parent 2b9f5bcd1f
commit df65810b10

View file

@ -1125,9 +1125,11 @@ export class MetadataIndexManager {
if (!this.shouldIndexField(fullKey)) continue
// Special handling for metadata field at top level
// If this is an entity structure, recurse into metadata with prefix
// v4.8.0: Flatten metadata fields to top-level (no prefix) for cleaner queries
// Standard fields are already at top-level, custom fields go in metadata
// By flattening here, queries can use { category: 'B' } instead of { 'metadata.category': 'B' }
if (key === 'metadata' && !prefix && typeof value === 'object' && !Array.isArray(value)) {
extract(value, 'metadata')
extract(value, '') // Flatten to top-level, no prefix
continue
}