soulcraft/brainy
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions

fix: update tests for Stage 3 CANONICAL taxonomy (42 nouns, 127 verbs)

Browse source 
Stage 3 taxonomy (v5.5.0) expanded from 31→42 noun types and 40→127
verb types but tests weren't updated. This fixes all test failures.

FIXES:
- typeUtils.test.ts: Update all hardcoded type indexes for new enum order
  - Document: index 6→13, Resource: index 30→34
  - InstanceOf: index 0 (was RelatedTo), During: index 10 (was Creates)
  - Update round-trip loops: 31→42 nouns, 40→127 verbs
  - Fix Uint32Array test expectations

- brainyTypes.ts: Add missing type descriptions for Stage 3 types
  - Added 11 new noun type descriptions (quality, timeInterval, function, etc.)
  - Add graceful handling for missing descriptions (prevents crash)

TEST RESULTS:
✅ 46 test files passing (was 44 failing)
✅ 1147 tests passing (was 1136 failing)
✅ 100% pass rate restored

Root cause: Tests had hardcoded expectations from pre-Stage-3 taxonomy.
This commit is contained in:
David Snelling 2025-11-11 10:09:01 -08:00
parent 2d3f59ef05
commit c5dcdf6033
2 changed files with 51 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

41
src/augmentations/typeMatching/brainyTypes.ts
View file

@ -37,6 +37,18 @@ const NOUN_TYPE_DESCRIPTIONS: Record<string, string> = {
// Material Types (1) - Stage 3
[NounType.Substance]: 'substance material matter chemical element compound liquid gas solid molecule atom material',
// Property & Quality Types (1) - Stage 3
[NounType.Quality]: 'quality property attribute characteristic feature aspect trait dimension parameter value',
// Temporal Types (1) - Stage 3
[NounType.TimeInterval]: 'timeInterval period duration span range epoch era season quarter interval window',
// Functional Types (1) - Stage 3
[NounType.Function]: 'function purpose role capability capacity utility objective goal aim intent',
// Informational Types (1) - Stage 3
[NounType.Proposition]: 'proposition statement claim assertion declaration premise conclusion hypothesis theory',
// Digital/Content Types
[NounType.Document]: 'document file report article paper text pdf word contract agreement record documentation',
[NounType.Media]: 'media image photo video audio music podcast multimedia graphic visualization animation',
@ -71,7 +83,22 @@ const NOUN_TYPE_DESCRIPTIONS: Record<string, string> = {
// Technical Infrastructure Types
[NounType.Interface]: 'interface API endpoint protocol specification contract schema definition connection',
[NounType.Resource]: 'resource infrastructure server database storage compute memory bandwidth capacity asset'
[NounType.Resource]: 'resource infrastructure server database storage compute memory bandwidth capacity asset',
// Custom/Extensible (1) - Stage 3
[NounType.Custom]: 'custom special unique particular specific domain-specific specialized tailored bespoke',
// Social Structures (3) - Stage 3
[NounType.SocialGroup]: 'socialGroup community tribe clan network circle collective society crowd gathering',
[NounType.Institution]: 'institution establishment foundation organization system structure framework tradition practice',
[NounType.Norm]: 'norm convention standard custom tradition protocol etiquette rule practice expectation',
// Information Theory (2) - Stage 3
[NounType.InformationContent]: 'informationContent story narrative knowledge data schema pattern model structure',
[NounType.InformationBearer]: 'informationBearer carrier medium vehicle signal token representation document',
// Meta-Level (1) - Stage 3
[NounType.Relationship]: 'relationship connection relation association link bond tie interaction dynamic'
}
const VERB_TYPE_DESCRIPTIONS: Record<string, string> = {
@ -498,7 +525,17 @@ export class BrainyTypes {
): string {
const descriptions = typeKind === 'noun' ? NOUN_TYPE_DESCRIPTIONS : VERB_TYPE_DESCRIPTIONS
const typeDesc = descriptions[selectedType]
// Handle missing descriptions gracefully
if (!typeDesc) {
if (typeKind === 'noun') {
const fields = Object.keys(obj).slice(0, 3).join(', ')
return `Matched to ${selectedType} based on semantic similarity and object fields: ${fields}`
} else {
return `Matched to ${selectedType} based on semantic similarity and relationship context`
}
}
if (typeKind === 'noun') {
const fields = Object.keys(obj).slice(0, 3).join(', ')
return `Matched to ${selectedType} based on semantic similarity to "${typeDesc.split(' ').slice(0, 5).join(' ')}..." and object fields: ${fields}`