fix: flush graph LSM-trees on close to prevent data loss across restarts

GraphAdjacencyIndex.flush() was a no-op — LSM MemTables were never
written to SSTables for datasets under the 100K auto-flush threshold.
This caused readdir, getRelations, and getDescendants to return empty
results after close + reopen.

Three fixes:
- LSMTree.get(): merge MemTable + SSTable results (data spans both
  after flush, old early-return missed SSTable data)
- GraphAdjacencyIndex.flush(): actually flush all 4 LSM-trees
- GraphAdjacencyIndex.close(): close all 4 trees (was only closing 2)

Also: brain.close() and shutdown hooks now call close() on graphIndex,
HNSW index, and metadataIndex to release timers and file handles.
This commit is contained in:
David Snelling 2026-02-01 17:55:40 -08:00
parent 0add0af45a
commit ab2493af02
4 changed files with 213 additions and 22 deletions

View file

@ -0,0 +1,133 @@
/**
* Regression test: VFS data persists across restart (close + reopen)
*
* Verifies the fix for GraphAdjacencyIndex.flush() and LSMTree.get()
* which previously caused graph relationships to be lost on restart
* because LSM MemTables were never flushed to SSTables on close.
*/
import { describe, it, expect } from 'vitest'
import { Brainy } from '../../src/brainy.js'
import { VerbType } from '../../src/types/graphTypes.js'
import { mkdirSync, rmSync } from 'fs'
describe('VFS restart persistence', () => {
it('entities and relationships survive close + reopen', async () => {
const dir = '/tmp/brainy-restart-fix-' + Date.now()
mkdirSync(dir, { recursive: true })
let entityId: string | undefined
const rootId = '00000000-0000-0000-0000-000000000000'
try {
// === SESSION 1: Write data ===
let brain = new Brainy({
storage: { type: 'filesystem', rootDirectory: dir },
disableAutoRebuild: true,
plugins: [],
silent: true,
})
await brain.init()
await brain.vfs.writeFile('/chapter-1.txt', 'Once upon a time...')
entityId = await brain.vfs.resolvePathToId('/chapter-1.txt')
expect(entityId).toBeTruthy()
// Verify within same session
const entity1 = await brain.get(entityId!)
expect(entity1).not.toBeNull()
const entries1 = await brain.vfs.readdir('/')
expect(entries1.length).toBeGreaterThan(0)
await brain.close()
// === SESSION 2: Read data after restart ===
brain = new Brainy({
storage: { type: 'filesystem', rootDirectory: dir },
disableAutoRebuild: true,
plugins: [],
silent: true,
})
await brain.init()
// Entity should be retrievable
const entity2 = await brain.get(entityId!)
expect(entity2).not.toBeNull()
// Root entity should exist
const rootEntity = await brain.get(rootId)
expect(rootEntity).not.toBeNull()
// readdir should return the file
const entries2 = await brain.vfs.readdir('/')
expect(entries2.length).toBeGreaterThan(0)
expect(entries2).toContain('chapter-1.txt')
// getRelations should find the Contains relationship
const relations2 = await brain.getRelations({ from: rootId, type: VerbType.Contains })
expect(relations2.length).toBeGreaterThan(0)
await brain.close()
} finally {
try { rmSync(dir, { recursive: true }) } catch {}
}
})
it('multiple files and subdirectories survive restart', async () => {
const dir = '/tmp/brainy-restart-multi-' + Date.now()
mkdirSync(dir, { recursive: true })
const rootId = '00000000-0000-0000-0000-000000000000'
try {
// === SESSION 1: Write multiple files ===
let brain = new Brainy({
storage: { type: 'filesystem', rootDirectory: dir },
disableAutoRebuild: true,
plugins: [],
silent: true,
})
await brain.init()
await brain.vfs.writeFile('/readme.txt', 'Project readme')
await brain.vfs.writeFile('/docs/guide.txt', 'User guide')
await brain.vfs.writeFile('/docs/api.txt', 'API reference')
const entries1 = await brain.vfs.readdir('/')
expect(entries1.length).toBe(2) // readme.txt + docs/
const docEntries1 = await brain.vfs.readdir('/docs')
expect(docEntries1.length).toBe(2) // guide.txt + api.txt
await brain.close()
// === SESSION 2: Verify all data persisted ===
brain = new Brainy({
storage: { type: 'filesystem', rootDirectory: dir },
disableAutoRebuild: true,
plugins: [],
silent: true,
})
await brain.init()
// Root children
const entries2 = await brain.vfs.readdir('/')
expect(entries2.length).toBe(2)
expect(entries2.sort()).toEqual(['docs', 'readme.txt'])
// Subdirectory children
const docEntries2 = await brain.vfs.readdir('/docs')
expect(docEntries2.length).toBe(2)
expect(docEntries2.sort()).toEqual(['api.txt', 'guide.txt'])
// Root relations
const rootRelations = await brain.getRelations({ from: rootId, type: VerbType.Contains })
expect(rootRelations.length).toBeGreaterThan(0)
await brain.close()
} finally {
try { rmSync(dir, { recursive: true }) } catch {}
}
})
})