fix: resolve critical COW ref resolution and versioning bugs
Fixed three critical bugs in v5.3.0: 1. COW ref resolution bug (lines 2354, 2856, 2895 in src/brainy.ts): - getHistory(), commit(), deleteBranch() were prepending 'heads/' to branch names - This caused RefManager to resolve 'heads/main' to 'refs/heads/heads/main' - Actual ref file at 'refs/heads/main' could not be found - Result: "Ref not found: heads/main" error breaking all COW operations 2. VersionManager commitHash bug (lines 212, 222 in src/versioning/VersionManager.ts): - save() was assigning entire Ref object to commitHash instead of ref.commitHash - Expected string, got object causing type mismatches in version metadata 3. Test mock improvements (tests/unit/versioning/VersionManager.test.ts): - Fixed searchByMetadata to skip metadata check for 'type' property - Added glob pattern support for tag filtering (e.g. 'v1.*') - Added deleteNounMetadata mock - Fixed getNounMetadata to return null for missing version entities Fixes: - src/brainy.ts (3 lines): Remove 'heads/' prefix from ref resolution calls - src/versioning/VersionManager.ts (2 lines): Use ref.commitHash instead of ref - tests/unit/versioning/VersionManager.test.ts: Fix test mocks - tests/integration/history-ref-resolution-bug.test.ts: Add regression tests Test Results: - Before: 16 test failures - After: 0 failures in VersionManager tests, 1183/1208 total tests passing (98%)
This commit is contained in:
parent
6e2c93e03a
commit
9db67d0148
4 changed files with 175 additions and 10 deletions
|
|
@ -2351,7 +2351,7 @@ export class Brainy<T = any> implements BrainyInterface<T> {
|
|||
const currentBranch = await this.getCurrentBranch()
|
||||
|
||||
// Get current HEAD commit (parent)
|
||||
const currentCommitHash = await refManager.resolveRef(`heads/${currentBranch}`)
|
||||
const currentCommitHash = await refManager.resolveRef(currentBranch)
|
||||
|
||||
// Get current state statistics
|
||||
const entityCount = await this.getNounCount()
|
||||
|
|
@ -2853,7 +2853,7 @@ export class Brainy<T = any> implements BrainyInterface<T> {
|
|||
}
|
||||
|
||||
const refManager = (this.storage as any).refManager
|
||||
await refManager.deleteRef(`heads/${branch}`)
|
||||
await refManager.deleteRef(branch)
|
||||
})
|
||||
}
|
||||
|
||||
|
|
@ -2892,7 +2892,7 @@ export class Brainy<T = any> implements BrainyInterface<T> {
|
|||
const currentBranch = await this.getCurrentBranch()
|
||||
|
||||
// Get commit history for current branch
|
||||
const commits = await commitLog.getHistory(`heads/${currentBranch}`, {
|
||||
const commits = await commitLog.getHistory(currentBranch, {
|
||||
maxCount: options?.limit || 10
|
||||
})
|
||||
|
||||
|
|
|
|||
|
|
@ -209,7 +209,7 @@ export class VersionManager {
|
|||
// Get the commit hash that was just created
|
||||
const refManager = this.brain.refManager
|
||||
const ref = await refManager.getRef(currentBranch)
|
||||
commitHash = ref
|
||||
commitHash = ref.commitHash
|
||||
} else {
|
||||
// Use current HEAD commit
|
||||
const refManager = this.brain.refManager
|
||||
|
|
@ -219,7 +219,7 @@ export class VersionManager {
|
|||
`No commit exists on branch ${currentBranch}. Create a commit first or use createCommit: true`
|
||||
)
|
||||
}
|
||||
commitHash = ref
|
||||
commitHash = ref.commitHash
|
||||
}
|
||||
|
||||
// Create version metadata
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue