soulcraft/brainy
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions

fix: return minimal stats with counts when statistics don't exist

Browse source 
Previously, when no statistics file existed (e.g., first container restart
after adding entities), getStatisticsData() returned null, causing HNSW
rebuild to see entityCount=0 even though entities existed.

This fix ensures all storage adapters return minimal StatisticsData with
totalNodes/totalEdges populated from in-memory counts when statistics files
don't exist yet.

Changes:
- gcsStorage.ts: Return minimal stats instead of null on 404 errors
- memoryStorage.ts: Return minimal stats when statistics is null
- opfsStorage.ts: Return minimal stats on read errors and null checks
- s3CompatibleStorage.ts: Return minimal stats when no statistics found
- fileSystemStorage.ts: Use in-memory counts in mergeStatistics() null case

This completes the GCS persistence fix started in v3.37.3 and ensures
container restarts work correctly in all cloud environments.

Fixes: GCS container restart hang during HNSW index rebuild
This commit is contained in:
David Snelling 2025-10-11 09:05:16 -07:00
parent e9718b0145
commit 968e7daeab
5 changed files with 88 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/storage/adapters/opfsStorage.ts
View file

@ -1438,14 +1438,38 @@ export class OPFSStorage extends BaseStorage {
}
}
} catch (error) {
// If the legacy file doesn't exist either, return null
return null
// CRITICAL FIX (v3.37.4): No statistics files exist (first init)
// Return minimal stats with counts instead of null
// This prevents HNSW from seeing entityCount=0 during index rebuild
return {
nounCount: {},
verbCount: {},
metadataCount: {},
hnswIndexSize: 0,
totalNodes: this.totalNounCount,
totalEdges: this.totalVerbCount,
totalMetadata: 0,
lastUpdated: new Date().toISOString()
}
}
}
}
// If we get here and statistics is null, return default statistics
return this.statistics ? this.statistics : null
// If we get here and statistics is null, return minimal stats with counts
if (!this.statistics) {
return {
nounCount: {},
verbCount: {},
metadataCount: {},
hnswIndexSize: 0,
totalNodes: this.totalNounCount,
totalEdges: this.totalVerbCount,
totalMetadata: 0,
lastUpdated: new Date().toISOString()
}
}
return this.statistics
} catch (error) {
console.error('Failed to get statistics data:', error)
throw new Error(`Failed to get statistics data: ${error}`)