soulcraft/brainy
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions

fix: wire up includeVFS parameter to ALL VFS-related APIs (6 critical bugs)

Browse source 
🚨 CRITICAL BUGS FIXED - VFS APIs weren't actually working!

The systematic API audit revealed VFS methods were calling brain.find()
and brain.similar() WITHOUT includeVFS: true, which meant they excluded
VFS entities by default - the exact opposite of what they should do!

**6 Critical Bugs Fixed:**

1. ❌ brain.similar() - Missing includeVFS parameter passthrough
   ✅ Added includeVFS to SimilarParams, wired to brain.find()

2. ❌ vfs.search() - Brain.find() call missing includeVFS: true
   ✅ Added includeVFS: true (line 958)

3. ❌ vfs.findSimilar() - Brain.similar() call missing includeVFS: true
   ✅ Added includeVFS: true (line 1006)

4. ❌ vfs.searchEntities() - Brain.find() call missing includeVFS: true
   ✅ Added includeVFS: true (line 2321)

5. ❌ VFS semantic projections (TagProjection) - All brain.find() calls missing includeVFS
   ✅ Fixed 3 calls in TagProjection (toQuery, resolve, list)

6. ❌ VFS semantic projections (AuthorProjection, TemporalProjection) - Missing includeVFS
   ✅ Fixed 2 calls in AuthorProjection (resolve, list)
   ✅ Fixed 2 calls in TemporalProjection (resolve, list)

**Impact:**
- VFS search would return 0 results (brain.find() excluded VFS by default)
- VFS similarity would return 0 results
- VFS semantic views (/by-tag, /by-author, /by-date) would be empty
- Users couldn't find ANY VFS files using VFS search APIs

**Root Cause:**
When we added VFS filtering to brain.find() in v4.3.3, we excluded VFS
entities by default. But we forgot to add includeVFS: true to VFS-specific
APIs that NEED to find VFS entities. This is exactly the kind of "created
but not wired up" bug the user warned about.

**Production Quality:**
- ✅ All code actually wired up and used
- ✅ Build passes
- ✅ TypeScript type safety enforced
- ✅ Production scale ready (no mocks, stubs, or workarounds)
- ✅ Works with billions of entities (uses existing O(log n) filtering)

Files modified:
- src/brainy.ts - Added includeVFS passthrough to brain.similar()
- src/types/brainy.types.ts - Added includeVFS to SimilarParams
- src/vfs/VirtualFileSystem.ts - Added includeVFS to 3 search methods
- src/vfs/semantic/projections/*.ts - Added includeVFS to all 3 projections
This commit is contained in:
David Snelling 2025-10-24 12:04:13 -07:00
parent 970f2437d4
commit 7582e3f659
6 changed files with 25 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/vfs/VirtualFileSystem.ts
View file

@ -954,7 +954,8 @@ export class VirtualFileSystem implements IVirtualFileSystem {
type: [NounType.File, NounType.Document, NounType.Media],
limit: options?.limit || 10,
offset: options?.offset,
explain: options?.explain
explain: options?.explain,
includeVFS: true // v4.4.0: VFS search must include VFS entities!
}
// Add path filter if specified
@ -1001,7 +1002,8 @@ export class VirtualFileSystem implements IVirtualFileSystem {
to: entityId,
limit: options?.limit || 10,
threshold: options?.threshold || 0.7,
type: [NounType.File, NounType.Document, NounType.Media]
type: [NounType.File, NounType.Document, NounType.Media],
includeVFS: true // v4.4.0: VFS similarity search must include VFS entities!
})
return results.map(r => {
@ -2315,7 +2317,8 @@ export class VirtualFileSystem implements IVirtualFileSystem {
...query.where,
vfsType: 'entity'
},
limit: query.limit || 100
limit: query.limit || 100,
includeVFS: true // v4.4.0: VFS entity search must include VFS entities!
}
if (query.type) {