fix: createEntities defaults to true, enable AI features by default
CRITICAL FIX: createEntities was treating undefined as false, causing imports
to skip graph entity creation. Only VFS wrappers were created, breaking type filtering.
Fixes:
- createEntities now defaults to true when undefined (line 736)
- Fixed option spreading order (spread options first, then apply defaults) (line 357)
- Enabled enableRelationshipInference by default (AI relationships)
- Enabled enableNeuralExtraction by default (smart entity extraction)
- Enabled enableConceptExtraction by default (concept mining)
Root Cause:
1. Line 733: if (!options.createEntities) treated undefined as false
2. Line 361: ...options spread AFTER defaults, overwriting them with undefined
Result: Graph entities never created, only VFS wrappers
Impact:
- Workshop team: 0 results for brain.find({ type: 'person' })
- Type filtering completely broken
- HNSW showed entities (read from VFS) but storage had none
Tests Added:
- tests/unit/create-entities-default.test.ts (3 scenarios)
- tests/integration/vfs-and-graph-entities.test.ts (15 assertions, end-to-end)
- tests/integration/relationship-intelligence.test.ts (relationship verification)
- tests/unit/type-filtering.unit.test.ts (8 type filtering tests)
All tests pass ✅
Breaking Changes: None - this restores intended default behavior
Workshop Resolution: Clear ./brainy-data and re-import with v4.3.2.
Type filtering will work immediately.
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
parent
a86e86c61b
commit
5c84be0276
5 changed files with 710 additions and 3 deletions
150
tests/unit/create-entities-default.test.ts
Normal file
150
tests/unit/create-entities-default.test.ts
Normal file
|
|
@ -0,0 +1,150 @@
|
|||
/**
|
||||
* Test for createEntities default value bug fix (v4.3.2)
|
||||
*
|
||||
* Bug: If createEntities was undefined, it defaulted to false
|
||||
* Fix: Now defaults to true when undefined
|
||||
*/
|
||||
|
||||
import { describe, it, expect, beforeEach } from 'vitest'
|
||||
import { Brainy, NounType } from '../../src/index.js'
|
||||
import * as fs from 'fs'
|
||||
import * as path from 'path'
|
||||
|
||||
describe('createEntities Default Value (v4.3.2 Bug Fix)', () => {
|
||||
let brain: Brainy
|
||||
const testDir = './test-create-entities-default'
|
||||
|
||||
beforeEach(async () => {
|
||||
// Clean up test directory
|
||||
if (fs.existsSync(testDir)) {
|
||||
fs.rmSync(testDir, { recursive: true })
|
||||
}
|
||||
|
||||
brain = new Brainy({
|
||||
storage: {
|
||||
type: 'filesystem',
|
||||
path: testDir
|
||||
}
|
||||
})
|
||||
await brain.init()
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
// Clean up test directory
|
||||
if (fs.existsSync(testDir)) {
|
||||
fs.rmSync(testDir, { recursive: true })
|
||||
}
|
||||
})
|
||||
|
||||
it('should create graph entities when createEntities is undefined (default behavior)', async () => {
|
||||
// Create a minimal CSV to import
|
||||
const csvContent = `Name,Type
|
||||
Alice,person
|
||||
Bob,person
|
||||
New York,location`
|
||||
|
||||
const csvPath = path.join(testDir, 'test.csv')
|
||||
fs.mkdirSync(testDir, { recursive: true })
|
||||
fs.writeFileSync(csvPath, csvContent)
|
||||
|
||||
// Import WITHOUT specifying createEntities (should default to true)
|
||||
const result = await brain.import(csvPath, {
|
||||
vfsPath: '/imports/test',
|
||||
groupBy: 'flat'
|
||||
// NOTE: createEntities is NOT specified - should default to true
|
||||
})
|
||||
|
||||
console.log('\n📊 Import Result:')
|
||||
console.log(` Entities created: ${result.stats.graphNodesCreated}`)
|
||||
console.log(` VFS files created: ${result.stats.vfsFilesCreated}`)
|
||||
|
||||
// Verify graph entities were created
|
||||
expect(result.stats.graphNodesCreated).toBeGreaterThan(0)
|
||||
|
||||
// Verify we can query by type
|
||||
const people = await brain.find({ type: NounType.Person, limit: 10 })
|
||||
console.log(`\n🔍 Type Filtering:`)
|
||||
console.log(` Person filter: ${people.length}`)
|
||||
|
||||
expect(people.length).toBeGreaterThan(0)
|
||||
expect(people.length).toBeLessThanOrEqual(2) // Should be 2 or less (Alice, Bob)
|
||||
|
||||
const locations = await brain.find({ type: NounType.Location, limit: 10 })
|
||||
console.log(` Location filter: ${locations.length}`)
|
||||
|
||||
expect(locations.length).toBeGreaterThan(0)
|
||||
expect(locations.length).toBeLessThanOrEqual(1) // Should be 1 or less (New York)
|
||||
|
||||
console.log('\n✅ Graph entities created by default!')
|
||||
})
|
||||
|
||||
it('should NOT create graph entities when createEntities is explicitly false', async () => {
|
||||
// Create a minimal CSV to import
|
||||
const csvContent = `Name,Type
|
||||
Alice,person
|
||||
Bob,person`
|
||||
|
||||
const csvPath = path.join(testDir, 'test2.csv')
|
||||
fs.mkdirSync(testDir, { recursive: true })
|
||||
fs.writeFileSync(csvPath, csvContent)
|
||||
|
||||
// Import WITH createEntities: false
|
||||
const result = await brain.import(csvPath, {
|
||||
vfsPath: '/imports/test2',
|
||||
groupBy: 'flat',
|
||||
createEntities: false // Explicitly disable
|
||||
})
|
||||
|
||||
console.log('\n📊 Import Result (createEntities: false):')
|
||||
console.log(` Entities created: ${result.stats.graphNodesCreated}`)
|
||||
console.log(` VFS files created: ${result.stats.vfsFilesCreated}`)
|
||||
|
||||
// Verify NO graph entities were created
|
||||
expect(result.stats.graphNodesCreated).toBe(0)
|
||||
|
||||
// Verify VFS files were still created
|
||||
expect(result.stats.vfsFilesCreated).toBeGreaterThan(0)
|
||||
|
||||
// Verify type filtering returns 0 (no graph entities)
|
||||
const people = await brain.find({ type: NounType.Person, limit: 10 })
|
||||
console.log(`\n🔍 Type Filtering:`)
|
||||
console.log(` Person filter: ${people.length}`)
|
||||
|
||||
expect(people.length).toBe(0)
|
||||
|
||||
console.log('\n✅ Graph entities NOT created when explicitly disabled!')
|
||||
})
|
||||
|
||||
it('should create graph entities when createEntities is explicitly true', async () => {
|
||||
// Create a minimal CSV to import
|
||||
const csvContent = `Name,Type
|
||||
Charlie,person`
|
||||
|
||||
const csvPath = path.join(testDir, 'test3.csv')
|
||||
fs.mkdirSync(testDir, { recursive: true })
|
||||
fs.writeFileSync(csvPath, csvContent)
|
||||
|
||||
// Import WITH createEntities: true
|
||||
const result = await brain.import(csvPath, {
|
||||
vfsPath: '/imports/test3',
|
||||
groupBy: 'flat',
|
||||
createEntities: true // Explicitly enable
|
||||
})
|
||||
|
||||
console.log('\n📊 Import Result (createEntities: true):')
|
||||
console.log(` Entities created: ${result.stats.graphNodesCreated}`)
|
||||
console.log(` VFS files created: ${result.stats.vfsFilesCreated}`)
|
||||
|
||||
// Verify graph entities were created
|
||||
expect(result.stats.graphNodesCreated).toBeGreaterThan(0)
|
||||
|
||||
// Verify type filtering works
|
||||
const people = await brain.find({ type: NounType.Person, limit: 10 })
|
||||
console.log(`\n🔍 Type Filtering:`)
|
||||
console.log(` Person filter: ${people.length}`)
|
||||
|
||||
expect(people.length).toBeGreaterThan(0)
|
||||
|
||||
console.log('\n✅ Graph entities created when explicitly enabled!')
|
||||
})
|
||||
})
|
||||
121
tests/unit/type-filtering.unit.test.ts
Normal file
121
tests/unit/type-filtering.unit.test.ts
Normal file
|
|
@ -0,0 +1,121 @@
|
|||
/**
|
||||
* Type Filtering Tests - Workshop Team Issue
|
||||
*
|
||||
* Tests to verify that brain.find({ type: NounType.X }) correctly filters entities
|
||||
*/
|
||||
|
||||
import { describe, it, expect, beforeEach } from 'vitest'
|
||||
import { Brainy, NounType } from '../../src/index.js'
|
||||
|
||||
describe('Type Filtering (Workshop Team Issue)', () => {
|
||||
let brain: Brainy
|
||||
|
||||
beforeEach(async () => {
|
||||
brain = new Brainy({
|
||||
storage: { type: 'memory' }
|
||||
})
|
||||
await brain.init()
|
||||
})
|
||||
|
||||
it('should filter entities by NounType.Person', async () => {
|
||||
// Add 3 people
|
||||
await brain.add({ data: 'John Smith', type: NounType.Person, metadata: { name: 'John' } })
|
||||
await brain.add({ data: 'Jane Doe', type: NounType.Person, metadata: { name: 'Jane' } })
|
||||
await brain.add({ data: 'Bob Johnson', type: NounType.Person, metadata: { name: 'Bob' } })
|
||||
|
||||
// Add 2 locations
|
||||
await brain.add({ data: 'New York', type: NounType.Location, metadata: { name: 'NYC' } })
|
||||
await brain.add({ data: 'London', type: NounType.Location, metadata: { name: 'London' } })
|
||||
|
||||
// Test: Filter by person
|
||||
const results = await brain.find({ type: NounType.Person, limit: 100 })
|
||||
|
||||
expect(results.length).toBe(3)
|
||||
expect(results.every(r => r.type === 'person')).toBe(true)
|
||||
})
|
||||
|
||||
it('should filter entities by string type "person"', async () => {
|
||||
// Add 2 people
|
||||
await brain.add({ data: 'Person 1', type: NounType.Person })
|
||||
await brain.add({ data: 'Person 2', type: NounType.Person })
|
||||
|
||||
// Add 1 location
|
||||
await brain.add({ data: 'Location 1', type: NounType.Location })
|
||||
|
||||
// Test: Filter by string
|
||||
const results = await brain.find({ type: 'person' as any, limit: 100 })
|
||||
|
||||
expect(results.length).toBe(2)
|
||||
})
|
||||
|
||||
it('should filter entities by NounType.Location', async () => {
|
||||
await brain.add({ data: 'Person 1', type: NounType.Person })
|
||||
await brain.add({ data: 'Location 1', type: NounType.Location })
|
||||
await brain.add({ data: 'Location 2', type: NounType.Location })
|
||||
|
||||
const results = await brain.find({ type: NounType.Location, limit: 100 })
|
||||
|
||||
expect(results.length).toBe(2)
|
||||
expect(results.every(r => r.type === 'location')).toBe(true)
|
||||
})
|
||||
|
||||
it('should filter entities by NounType.Concept', async () => {
|
||||
await brain.add({ data: 'Concept 1', type: NounType.Concept })
|
||||
await brain.add({ data: 'Person 1', type: NounType.Person })
|
||||
|
||||
const results = await brain.find({ type: NounType.Concept, limit: 100 })
|
||||
|
||||
expect(results.length).toBe(1)
|
||||
expect(results[0].type).toBe('concept')
|
||||
})
|
||||
|
||||
it('should filter by multiple types', async () => {
|
||||
await brain.add({ data: 'Person 1', type: NounType.Person })
|
||||
await brain.add({ data: 'Location 1', type: NounType.Location })
|
||||
await brain.add({ data: 'Concept 1', type: NounType.Concept })
|
||||
|
||||
const results = await brain.find({
|
||||
type: [NounType.Person, NounType.Location],
|
||||
limit: 100
|
||||
})
|
||||
|
||||
expect(results.length).toBe(2)
|
||||
expect(results.every(r => r.type === 'person' || r.type === 'location')).toBe(true)
|
||||
})
|
||||
|
||||
it('should return empty array when filtering by non-existent type', async () => {
|
||||
await brain.add({ data: 'Person 1', type: NounType.Person })
|
||||
|
||||
const results = await brain.find({ type: NounType.Organization, limit: 100 })
|
||||
|
||||
expect(results.length).toBe(0)
|
||||
})
|
||||
|
||||
it('should return all entities when no type filter is provided', async () => {
|
||||
await brain.add({ data: 'Person 1', type: NounType.Person })
|
||||
await brain.add({ data: 'Location 1', type: NounType.Location })
|
||||
await brain.add({ data: 'Concept 1', type: NounType.Concept })
|
||||
|
||||
const results = await brain.find({ limit: 100 })
|
||||
|
||||
expect(results.length).toBe(3)
|
||||
})
|
||||
|
||||
it('should verify entity type is set correctly', async () => {
|
||||
const id = await brain.add({
|
||||
data: 'Test Person',
|
||||
type: NounType.Person,
|
||||
metadata: { name: 'Test' }
|
||||
})
|
||||
|
||||
const entity = await brain.get(id)
|
||||
|
||||
// Check that the entity has the correct type
|
||||
expect(entity?.type).toBe('person')
|
||||
|
||||
// Verify metadata.noun is NOT exposed in public API
|
||||
// (it's an internal field, converted to entity.type)
|
||||
// @ts-ignore - accessing to verify it's NOT there
|
||||
expect(entity?.metadata?.noun).toBeUndefined()
|
||||
})
|
||||
})
|
||||
Loading…
Add table
Add a link
Reference in a new issue