soulcraft/brainy
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions

chore: hold loadBinaryBlob fault-propagation for the cortex column-store lockstep

Browse source 
The Pass-1 hardening made loadBinaryBlob distinguish genuine absence (ENOENT →
null) from a real fault (EIO/EACCES/… → throw), so a present-but-unreadable blob
stops masquerading as "absent". The native column-store still has two call sites
that rely on the old null-on-error contract; publishing the throw ahead of them
would break a consumer running new brainy + old cortex.

Per the cortex coordination (accept: cor first, then brainy), this temporarily
restores the shipped 8.2.5 swallow-on-fault behavior for loadBinaryBlob ONLY, so
the rest of Pass 1 — saveBinaryBlob write-honesty, clear() native wipe,
pending-flush durability, count symmetry, degraded surfacing, aggregation
loudness — can release now. The method carries an inline restore guide; the
throwing form goes back in and ships lockstep with the native hardening. No other
Pass-1 change depends on this behavior (ColumnStore's own fault test uses a
direct-throwing storage stub), so the split is behaviour-neutral for every
consumer versus 8.2.5.
This commit is contained in:
David Snelling 2026-07-13 10:44:11 -07:00
parent 02eff64b78
commit 36c10c1e20
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/storage/adapters/fileSystemStorage.ts
View file

@ -17,7 +17,6 @@ import {
WriterLockInfo WriterLockInfo
} from '../baseStorage.js' } from '../baseStorage.js'
import { getBrainyVersion } from '../../utils/index.js' import { getBrainyVersion } from '../../utils/index.js'
import { isAbsentError } from '../../utils/errorClassification.js'
// Node.js modules - dynamically imported to avoid issues in browser environments // Node.js modules - dynamically imported to avoid issues in browser environments
let fs: any let fs: any
@ -1229,14 +1228,25 @@ export class FileSystemStorage extends BaseStorage {
await this.ensureInitialized() await this.ensureInitialized()
try { try {
return await fs.promises.readFile(this.blobPath(key)) return await fs.promises.readFile(this.blobPath(key))
} catch (err) { } catch {
// Absent blob → null (the documented contract). A real fault // COORDINATION HOLD — restore the fault-propagating form lockstep with
// (EIO/EACCES/EMFILE/…) must NOT be masked as "absent": doing so makes a // cortex 3.0.13 (CORTEX-BILLION-SCALE-SPINE). The correct behavior
// present-but-unreadable blob look missing and drives a needless rebuild // distinguishes genuine absence from a real fault so a present-but-
// or an empty read (the native provider consumes this). Mandate: loud // unreadable blob no longer masquerades as "absent" (which drove needless
// errors, never quiet losses. // rebuilds / empty reads). Restore to:
if (isAbsentError(err)) return null // } catch (err) {
throw err // // re-add: import { isAbsentError } from '../../utils/errorClassification.js'
// if (isAbsentError(err)) return null
// throw err
// }
// The throw is HELD because the native column-store still has 2 call sites
// that rely on null-on-error; cortex hardens them in 3.0.13, then this
// reverts to the throwing form and ships lockstep. Until then this
// preserves the shipped 8.2.5 swallow-on-fault behavior, so a consumer on
// new-brainy + old-cortex can never break. All other Pass-1 hardening
// (saveBinaryBlob honesty, clear(), pending-flush durability, count
// symmetry, degraded surfacing, aggregation) ships now, independent of this.
return null
} }
} }