chore(8.0): final pre-RC1 sweep — API consistency, named errors, orphans, zero-cast codebase

This commit is contained in:
David Snelling 2026-06-11 14:51:00 -07:00
parent 970e08c466
commit 1f7e365a4e
237 changed files with 1951 additions and 49413 deletions

View file

@ -58,13 +58,11 @@ describe('Metadata Vector Exclusion Fix', () => {
// Check _system directory for chunk files
const systemDir = join(testDir, '_system')
if (!existsSync(systemDir)) {
// No chunk files created - this is acceptable
expect(true).toBe(true)
return
}
const chunkFiles = readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
// No _system dir means no chunk files at all — the invariant below
// (no vector-dimension chunks) holds trivially on an empty list.
const chunkFiles = existsSync(systemDir)
? readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
: []
// Should have at most a few chunk files (name, email, tags)
// NOT hundreds of files from vector dimensions
@ -105,12 +103,10 @@ describe('Metadata Vector Exclusion Fix', () => {
const systemDir = join(testDir, '_system')
if (!existsSync(systemDir)) {
expect(true).toBe(true)
return
}
const chunkFiles = readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
// No _system dir means no chunk files — the assertions below hold on [].
const chunkFiles = existsSync(systemDir)
? readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
: []
// CRITICAL: Check that NO chunk files have numeric field names
// This is the v3.50.2 fix - prevents vectors-as-objects from being indexed
@ -167,12 +163,10 @@ describe('Metadata Vector Exclusion Fix', () => {
// Check chunk count - should NOT create 100 chunk files
const systemDir = join(testDir, '_system')
if (!existsSync(systemDir)) {
expect(true).toBe(true)
return
}
const chunkFiles = readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
// No _system dir means no chunk files — the assertions below hold on [].
const chunkFiles = existsSync(systemDir)
? readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
: []
// Should have minimal chunk files (just 'name' field)
expect(chunkFiles.length).toBeLessThan(5)
@ -295,12 +289,10 @@ describe('Metadata Vector Exclusion Fix', () => {
// Check total chunk files
const systemDir = join(testDir, '_system')
if (!existsSync(systemDir)) {
expect(true).toBe(true)
return
}
const chunkFiles = readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
// No _system dir means no chunk files — the assertions below hold on [].
const chunkFiles = existsSync(systemDir)
? readdirSync(systemDir).filter(f => f.startsWith('__chunk__'))
: []
// Should have reasonable number of chunks (not 7,210 for 10 entities!)
// Expected: ~30 chunks (name, email, tags fields across 10 entities)