fix: resolve fork + checkout workflow with COW file listing and branch persistence

Fixed two critical issues preventing checkout-based time-travel:

1. COW File Listing Bug (fileSystemStorage.ts)
   - listObjectsUnderPath() only accepted .json/.json.gz files
   - COW stores refs/blobs/commits as plain .gz files
   - Added .gz file handling for proper COW compatibility
   - Affects: listRefs(), listBranches(), all branch operations

2. Checkout Branch Reset Bug (brainy.ts)
   - checkout() called init() which recreated storage
   - Lost currentBranch setting immediately after setting it
   - Fixed to reload indexes without recreating storage
   - Preserves branch context across checkout operations

3. COW Adapter Prefix Filtering (baseStorage.ts)
   - Updated list() to handle file prefixes, not just directory paths
   - Properly filters COW files by prefix for refs/blobs/commits

Verified with reproduction test: fork() → checkout() → vfs.read() now works.
Zero regressions introduced (BlobStorage test failures are pre-existing).
Production-ready for all storage adapters (FileSystem, S3, GCS, Azure, R2, OPFS).
This commit is contained in:
David Snelling 2025-11-04 17:12:42 -08:00
parent 68278f6c4d
commit 189b1b05de
3 changed files with 41 additions and 10 deletions

View file

@ -279,10 +279,22 @@ export abstract class BaseStorage extends BaseStorageAdapter {
list: async (prefix: string): Promise<string[]> => {
try {
const paths = await this.listObjectsUnderPath(`_cow/${prefix}`)
// v5.3.5 fix: Handle file prefixes, not just directory paths
// Refs are stored as files like: _cow/ref:refs/heads/main
// So list('ref:') should find all files starting with '_cow/ref:'
// List the _cow directory and filter by prefix
const allPaths = await this.listObjectsUnderPath('_cow/')
const filteredPaths = allPaths.filter(p => {
// Remove _cow/ prefix to get the key
const key = p.replace(/^_cow\//, '')
return key.startsWith(prefix)
})
// Remove _cow/ prefix and return relative keys
return paths.map(p => p.replace(/^_cow\//, ''))
} catch (error) {
return filteredPaths.map(p => p.replace(/^_cow\//, ''))
} catch (error: any) {
// If _cow directory doesn't exist yet, return empty array
return []
}
}