soulcraft/brainy
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 335 Packages Wiki Activity Actions

**refactor: improve imports, route handling, and environment detection**

Browse source 
### Changes:
- Added explicit `.js` extensions to imports in `cloud-wrapper/src/index.ts` for Node.js compatibility.
- Refactored `setupRoutes` usage by introducing an `apiRouter` variable for clarity and consistency in middleware.
- Simplified environment detection in `src/unified.ts` by delegating it to build-time logic:
  - Removed inline environment detection (`isBrowser`, `isNode`, `isServerless`).
  - Updated `environment` export with build-generated properties.

### Purpose:
Enhanced compatibility with Node.js module resolution, improved code clarity in route handling, and streamlined environment detection by consolidating it into the build process. These changes reduce redundancy, improve maintainability, and align with modern JavaScript practices.
This commit is contained in:
David Snelling 2025-06-19 16:03:31 -07:00
parent ced7c6eaec
commit 0cf4a0eee8
2 changed files with 11 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cloud-wrapper/src/index.ts
View file

@ -6,9 +6,9 @@ import dotenv from 'dotenv';
import http from 'http'; import http from 'http';
import { WebSocketServer } from 'ws'; import { WebSocketServer } from 'ws';
import { BrainyData } from '@soulcraft/brainy'; import { BrainyData } from '@soulcraft/brainy';
import { setupRoutes } from './routes'; import { setupRoutes } from './routes.js';
import { initializeBrainy } from './services/brainyService'; import { initializeBrainy } from './services/brainyService.js';
import { setupWebSocketHandlers } from './websocket'; import { setupWebSocketHandlers } from './websocket.js';
// Load environment variables // Load environment variables
dotenv.config(); dotenv.config();
@ -32,11 +32,12 @@ app.get('/health', (req, res) => {
}); });
// Setup API routes // Setup API routes
const apiRouter = setupRoutes();
app.use('/api', (req, res, next) => { app.use('/api', (req, res, next) => {
// Attach brainy instance to request // Attach brainy instance to request
(req as any).brainy = brainyInstance; (req as any).brainy = brainyInstance;
next(); next();
}, setupRoutes()); }, apiRouter);
// Start the server // Start the server
async function startServer() { async function startServer() {

17
src/unified.ts
View file

@ -1,20 +1,15 @@
/** /**
* Unified entry point for Brainy * Unified entry point for Brainy
* This file exports everything from index.ts and adds environment detection * This file exports everything from index.ts
* to ensure the library works in any environment (Node.js, browser, serverless) * Environment detection is handled by the build process
*/ */
// Environment detection (will be replaced by the build process)
const isBrowser = typeof window !== 'undefined'
const isNode =
typeof process !== 'undefined' && process.versions && process.versions.node
const isServerless = !isBrowser && !isNode
// Export environment information // Export environment information
// These values will be populated by the build process intro code
export const environment = { export const environment = {
isBrowser, isBrowser: typeof window !== 'undefined',
isNode, isNode: typeof process !== 'undefined' && process.versions && process.versions.node,
isServerless isServerless: typeof window === 'undefined' && (typeof process === 'undefined' || !process.versions || !process.versions.node)
} }
// Re-export everything from index.ts // Re-export everything from index.ts